Hi, +1 (binding)
Kind Regards, Furkan KAMACI On Wed, Apr 14, 2021 at 9:28 AM Fu Xiang <fx19880...@gmail.com> wrote: > Thanks, Justin, > > Which OS and maven version are you using? I just ran all the tests on my > ubuntu machine, and it's pretty stable. We will go through your > configuration during next release :P > > Best, > > Xiang > > On Tue, Apr 13, 2021 at 3:30 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > Changing my vote to +1 (binding). > > > > > Pinot has a nodejs based UI component under pinot-controller > > > < > > > https://github.com/apache/incubator-pinot/tree/release-0.7.1-rc0/pinot-controller/src/main/resources > > >. > > > Those dependencies are from the generated directories node_modules/dist > > > after the npm build, which were previously packaged into src dist and > > > removed since this version. > > > > Thanks for the explanation. > > > > > Can I ask for an exception for this release, and I will fix it before > the > > > next release? > > > > Well I guess having extra information in your LICENSE is not as bad as > > missing license information. Please correct this for the next release. > > > > > Regarding the test failing issue, are you running it using JDK 8? > > > > I was using JDK 8 yes. > > > > Thanks, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > -- > Xiang Fu >
