+1. I checked - Signatures and hashes are good. - Sources compiled successfully according to the doc. - All test cases are passed.
Best, Zhaofeng On Mon, Jun 7, 2021 at 8:16 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 binding, but only due to WIP disclaimer. The license issue, file header > and binary files issues will need to be fixed at some point. > > I also note that this release contains code under the GPL license, which > is not compatible with the Apache license and cannot be included in an ASF > source release. It would be good to note this in your disclaimer so that > users of this software are aware of this issue. Hopefully the PPMC is aware > of this issue and has a plan to remove or replace this software with > something that has a compatible license. > > I checked: > - Incubating in name > - signatures and hashes are fine > - WIP DISCLAIMER exists > - LICENSE needs more work > - NOTICE is fine > - There are unexpected binary files in the source release > - There a large number of source files without ASF header so it is not > easy to tell if files have the right headers or not > - didn’t compile from source > > Thanks. > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
