Felix and Justin,

Thanks for catching the file header issue.

I have created a PR to fix this in the next release. In this PR, I have
added the missing file headers and have added the Apache Rat check into the
standard publish process.

https://github.com/apache/incubator-sedona/pull/551

Thanks,
Jia


On Sun, Oct 3, 2021 at 6:36 PM Felix Cheung <felixche...@apache.org> wrote:

> +1
>
> Because of WIP DISCLAIMER
>
> On Sun, Oct 3, 2021 at 12:02 PM Felix Cheung <felixche...@apache.org>
> wrote:
>
> > - incubating in name
> > - signature and hash fine
> > - DISCLAIMER is fine
> > - LICENSE and NOTICE are fine
> > - No unexpected binary files
> >
> > - source files for ASF headers
> >
> > is there a reason this file doesn't have a header?
> >
> ./sql/src/main/scala/org/apache/spark/sql/sedona_sql/io/ImageOptions.scala
> >
> >
> > On Sun, Oct 3, 2021 at 12:17 AM Jia Yu <ji...@apache.org> wrote:
> >
> >> Hi all,
> >>
> >> This is a call for vote on Apache Sedona 1.1.0-incubating-rc1. This RC
> has
> >> passed the vote in the Sedona community.
> >>
> >> The result thread:
> >>
> >>
> https://lists.apache.org/thread.html/rb46d58958fd21b5af6f32486b08491e3d018bc1128d6e0819b663bdd%40%3Cdev.sedona.apache.org%3E
> >>
> >> Please refer to the changes listed at the bottom of this email.
> >>
> >> Release notes:
> >>
> >>
> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/docs/download/release-notes.md
> >>
> >> Build instructions:
> >>
> >>
> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/docs/download/compile.md
> >>
> >> GitHub tag:
> >>
> >>
> https://github.com/apache/incubator-sedona/releases/tag/sedona-1.1.0-incubating-rc1
> >>
> >> GPG public key to verify the Release:
> >> https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS
> >>
> >> Source code and binaries:
> >>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/sedona/1.1.0-incubating-rc1/
> >>
> >> The vote will be open for at least 72 hours or until a majority of at
> >> least
> >> 3 "approve" PMC votes are cast
> >>
> >> Please vote accordingly:
> >>
> >> [ ] +1 approve
> >>
> >> [ ] +0 no opinion
> >>
> >> [ ] -1 disapprove with the reason
> >>
> >> Checklist for reference (because of DISCLAIMER-WIP, other checklist
> items
> >> are not blockers):
> >>
> >> [ ] Download links are valid.
> >>
> >> [ ] Checksums and PGP signatures are valid.
> >>
> >> [ ] DISCLAIMER is included.
> >>
> >> [ ] Source code artifacts have correct names matching the current
> release.
> >>
> >> For a detailed checklist  please refer to:
> >>
> >>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >>
> >> Regards,
> >> Jia Yu
> >>
> >> ------------
> >> Changes according to the comments on the previous release
> >> Original comment (Permalink from https://lists.apache.org/list.html):
> >>
> >>
> https://lists.apache.org/thread.html/rcc3252c2afda7761afb205eb00a2f8a5d71256fc7f4d631efc879629%40%3Cgeneral.incubator.apache.org%3E
> >>
> >> 1. Fix the header issue in the BSD license
> >> This has been fixed.
> >>
> >> [1]
> >>
> >>
> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/zeppelin/index.js
> >> [2]
> >>
> >>
> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/licenses/LICENSE-zeppelin-helium-plugin
> >>
> >> 2. Add the license for scalastyle_config.xml
> >>
> >> [3]
> >>
> >>
> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/LICENSE#L210
> >>
> >> 3. Replace NASA HDF data with some alternatives to avoid the legal issue
> >>
> >> All NASA data has been removed from the repo.
> >>
> >
>

Reply via email to