The vote is now closed. It passes with 3 binding +1s and no -1. I will send the vote result email and announcement email later.
Thanks, Yuchen He On 2021/11/23 06:14:38 He Yuchen wrote: > Hi, DuoZhang, > > Thanks for your reminder about Pegasus-related projects. Pegasus community > plans to move corresponding projects such as pegasus-docker, > pegasus-java-client under the governance of ASF in future. > > As for the failure on unit test, it has no relationship with `libjvm.so`, and > I haven't met such error in my environment, I suppose that it is the > environment problem. I will try to reproduce such error. > > Thanks, > Yuchen He > > On 2021/11/22 05:36:34 "张铎(Duo Zhang)" wrote: > > +1(binding) > > > > Checked sigs and sums: Matched > > LICENSE and NOTICE: In place > > DISCLAIMER-WIP: In place > > Built from src: Succeeded with the steps mentioned here > > > > https://github.com/pegasus-kv/pegasus-docker > > > > I think we should also move this repo under the governance of ASF later. > > > > Run UTs: First it failed with can not find libjvm.so, I had to manually add > > the path for libjvm.so to the LD_LIBRARY_PATH, and this time I got a failure > > > > [----------] Global test environment tear-down > > [==========] 74 tests from 23 test cases ran. (43536 ms total) > > [ PASSED ] 73 tests. > > [ FAILED ] 1 test, listed below: > > [ FAILED ] pegasus_server_impl_test.test_table_level_slow_query > > > > I assume this is only for me? And considering the name, I guess this is > > just for performance, not correctness, so should not be a blocker. > > > > Thanks. > > > > Justin Mclean <jus...@classsoftware.com> 于2021年11月21日周日 下午3:48写道： > > > > > Hi, > > > > > > +1 (binding) because of WIP disclaimer > > > > > > I checked: > > > - incubating in name > > > - DISCLAIMER exists (WIP) > > > - signatures and hashes are fine > > > - NOTICE looks OK but given the large number of ALv2 code included I would > > > expect some of them to have NOTICE files > > > - From a quick quick LICENSE is missing some information. e.g this file > > > [1] (other others) which is confusingly has copyright claimed by two > > > companies or theses files [2][3] there are likely other files. > > > - All ASF files have ASF headers > > > - No unexpected binary files > > > - Can't compile from source but assume that’s my platform > > > > > > Kind Regards, > > > Justin > > > > > > 1. ./rdsn/src/utils/test/TokenBucketTest.cpp > > > 2. ./rdsn/bin/FindRT.cmake > > > 3. ./rdsn/scripts/linux/run-clang-format.py > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
