+1 (binding) from me, I have checked the following items: - Incubating in name - LICENSE and NOTICE are fine - DISCLAIMER-WIP exists - All links are valid - No unexpected binary files - All ASF files have ASF headers - Can compile from source in macOS - Checksums and PGP signatures are valid.
In addition, we need to include the LICENSE, NOTICE, DISCLAIMER files in each repo [1] [2], and we can make up these files in the next release. [1] https://github.com/apache/incubator-shenyu-dashboard [2] https://github.com/apache/incubator-shenyu-nginx Best regards, Xun Liu On Mon, Jan 24, 2022 at 10:29 AM jincheng sun <sunjincheng...@gmail.com> wrote: > +1 （binding） > > Checked: > - The download link works well > - The LICENSE and NOTICE files looks good > > Best, > Jincheng Sun > > > heng du <duhengfore...@apache.org> 于2022年1月22日周六 21:13写道： > > > +1 > > I checked： > > Download links are valid. > > No binary files in the source release. > > LICENSE and NOTICE files look good to me. > > License headers are checked with rat plugin. > > > > Willem Jiang <willem.ji...@gmail.com> 于2022年1月22日周六 09:02写道： > > > > > +1 （binding） > > > > > > I did these checks: > > > Download links of release candidates are valid. > > > Release kits have 'incubating' in the names. > > > No binary files in the source release. > > > LICENSE and NOTICE files look good to me. > > > License headers are checked with rat plugin. > > > I can build the source. > > > > > > Incubating > > > > > > Willem Jiang > > > > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > On Fri, Jan 21, 2022 at 10:01 PM 张磊 <sabers...@apache.org> wrote: > > > > > > > > Hello Incubator Community, > > > > > > > > This is a call for vote to release Apache ShenYu (incubating) version > > > 2.4.2 > > > > > > > > The Apache ShenYu community has voted on and approved a proposal to > > > release > > > > Apache ShenYu (incubating) version 2.4.2. > > > > > > > > We now kindly request the Incubator PMC members review and vote on > this > > > > incubator release. > > > > > > > > ShenYu community vote thread: > > > > > https://lists.apache.org/thread.html/wtv9zjloq32yklqcl9rcbzt53bs7lhl0 > > > > > > > > Vote result thread: > > > > https://lists.apache.org/thread/5odr88nf5r0o73l3c9fm0xqvhq8lctqr > > > > > > > > Release notes: > > > > > > https://github.com/apache/incubator-shenyu/blob/master/RELEASE-NOTES.md > > > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/incubator/shenyu/2.4.2/ > > > > > > > > Maven 2 staging repository: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheshenyu-1018/org/apache/shenyu/ > > > > > > > > Git tag for the release: > > > > https://github.com/apache/incubator-shenyu/tree/v2.4.2/ > > > > > > > > Release Commit ID: > > > > > > > > > > https://github.com/apache/incubator-shenyu/commit/794a3be979fc8f08e22e40f3ce75644df9c74dad > > > > > > > > Keys to verify the Release Candidate: > > > > https://downloads.apache.org/incubator/shenyu/KEYS > > > > > > > > Look at here for how to verify this release candidate: > > > > https://shenyu.apache.org/community/release-guide/#check-release > > > > > > > > GPG user ID: > > > > zhanglei > > > > > > > > The vote will be open for at least 72 hours or until necessary number > > of > > > > votes are reached. > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > > > > > [ ] +0 no opinion > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > Checklist for reference: > > > > > > > > [ ] Download links are valid. > > > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > > > [ ] Source code distributions have correct names matching the current > > > > release. > > > > > > > > [ ] LICENSE and NOTICE files are correct for each ShenYu repo. > > > > > > > > [ ] All files have license headers if necessary. > > > > > > > > [ ] No compiled archives bundled in source archive. > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > >
