Thanks to Dou for pointing the flaky test out.

I opened two tickets https://github.com/apache/incubator-kyuubi/issues/2430 and 
https://github.com/apache/incubator-kyuubi/issues/2431 for tracking. 

On 2022/04/21 00:52:20 "张铎(Duo Zhang)" wrote:
> +1(binding)
> 
> Checked sigs and sums: Matched
> LICENSE and NOTICE: In place
> DISCLAIMER: In place
> Built from source: 'mvn clean install -DskipTests' passed with jdk 1.8.0_312
> Run UTs: There are several failures, seems related to environment? See the
> output below for more details. Anyway I do not think it is a blocker.
> 
> Thanks.
> 
> ===== Failure Test Output =====
> Run starting. Expected test count is: 24
> ServiceControlCliArgumentsSuite:
> - test basic kyuubi service arguments parser *** FAILED ***
>   "[zhangduo-ubuntu]" did not equal "[localhost]"
> (ServiceControlCliArgumentsSuite.scala:99)
>   Analysis:
>   "[zhangduo-ubuntu]" -> "[localhost]"
> - prints usage on empty input
> - prints error with unrecognized options
> - test invalid arguments
> - test extra unused arguments
> - test list action arguments
> - test get/delete action arguments
> - test with unknown host
> - test with invalid port specification
> - test create action arguments
> - test use default property value if missing
> - test use short options *** FAILED ***
>   "[zhangduo-ubuntu]" did not equal "[localhost]"
> (ServiceControlCliArgumentsSuite.scala:333)
>   Analysis:
>   "[zhangduo-ubuntu]" -> "[localhost]"
> - test --help
> ServiceControlCliSuite:
> - test expose to same namespace
> - test not specified namespace
> - test expose to another namespace
> - test render zookeeper service node info
> - test expose zk service node to another namespace
> - test get zk namespace for different service type
> - test list zk service nodes info
> - test get zk service nodes info *** FAILED ***
>   "" did not contain "/kyuubiserver_03  localhost    10000
> 1.5.1-incubating
>   " (ServiceControlCliSuite.scala:75)
> - test delete zk service nodes info *** FAILED ***
>   "" did not contain "/kyuubiserver_04  localhost    10000
> 1.5.1-incubating
>   " (ServiceControlCliSuite.scala:75)
> - test verbose output
> - test get zk namespace for different engine type and subdomain
> Run completed in 34 seconds, 485 milliseconds.
> Total number of tests run: 24
> Suites: completed 3, aborted 0
> Tests: succeeded 20, failed 4, canceled 0, ignored 0, pending 0
> *** 4 TESTS FAILED ***
> 
> Fu Chen <fc...@apache.org> 于2022年4月20日周三 18:08写道:
> 
> > > But we may include too much information in the Notice file of binary
> > artifacts.
> >
> > Thanks to Willem for pointing this out.
> >
> > Compared with the last release, the content has been de-duplicated when
> > generation NOTICE. At present, there are still some cases of multiple
> > versions of the library that have not been covered, which will be addressed
> > in the next release.
> >
> > Fu Chen
> >
> > On 2022/04/20 08:46:48 Willem Jiang wrote:
> > > +1 (binding)
> > >
> > > I checked:
> > >
> > > The License and Notice files of source artifacts are good to me.
> > > But we may include too much information in the Notice file of binary
> > artifacts.
> > > The rat report of the License header  looks good to me.
> > > There is no binary in the source release kit.
> > > We have the incubating disclarm in the source file.
> > >
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > >
> > > On Mon, Apr 18, 2022 at 10:46 AM Fu Chen <cfmcgr...@gmail.com> wrote:
> > > >
> > > > Hello Incubator Community,
> > > >
> > > > The Apache Kyuubi community has voted on and approved a proposal to
> > release
> > > > Apache Kyuubi(Incubating) version v1.5.1-incubating rc0.
> > > >
> > > > We now kindly request the Incubator PMC members review and vote on this
> > > > incubator release.
> > > >
> > > > Kyuubi community vote thread:
> > > > https://www.mail-archive.com/dev@kyuubi.apache.org/msg02421.html
> > > >
> > > > Vote result thread:
> > > > https://www.mail-archive.com/dev@kyuubi.apache.org/msg02434.html
> > > >
> > > > [ ] +1 Release this package as Apache Kyuubi v1.5.1-incubating
> > > > [ ] +0
> > > > [ ] -1 Do not release this package because ...
> > > >
> > > > To learn more about Apache Kyuubi (Incubating), please see
> > > > https://kyuubi.apache.org/
> > > >
> > > > The tag to be voted on is v1.5.1-incubating-rc0 (commit
> > > > 84fb1c084a030a31e4766187818a0f2cb73b24cc):
> > > > https://github.com/apache/incubator-kyuubi/tree/v1.5.1-incubating-rc0
> > > >
> > > > The release files, including signatures, digests, etc. can be found at:
> > > >
> > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/v1.5.1-incubating-rc0/
> > > >
> > > > Signatures used for Kyuubi RCs can be found in this file:
> > > > https://downloads.apache.org/incubator/kyuubi/KEYS
> > > >
> > > > The staging repository for this release can be found at:
> > > >
> > https://repository.apache.org/content/repositories/orgapachekyuubi-1018/
> > > >
> > > > The release note is available in:
> > > >
> > https://github.com/apache/incubator-kyuubi/releases/tag/v1.5.1-incubating-rc0
> > > >
> > > >
> > > > Thanks,
> > > > On behalf of Apache Kyuubi(Incubating) community
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to