Thanks a lot for the review & suggestion I just send a CANCEL mail & will also address the GPL & binary problems before 2rd voting
On 2023/01/17 07:21:30 Justin Mclean wrote: > Hi, > > -1 (binding) > > In addition to the issues mentioned I can also see GPL licensed software > mentioned [1] and CC by [2]. ASF software cannot include or be dependant on > GPL software unless it is an optional dependancy, CC by should also not be > included. > > I also suggest you keep licenses (of dependancies) and notice files out of > the source release were they are not needed as it make reviewing the release > difficult. > > The ASF header has also been added incorrectly to 3rd party files e.g. [3] > and probably this [4] > > the apache-hugegraph-toolchain-incubating-1.0.0-src release also includes > compiled code. [5][6][7] > > Kind Regards, > Justin > > 1.https://www.apache.org/legal/resolved.html#category-x > 2. https://www.apache.org/legal/resolved.html#cc-by > 3. > ./computer-core/src/main/java/org/apache/hugegraph/computer/core/util/StringEncoding.java > 4. > ./hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java > 5../hugegraph-hubble/hubble-dist/assembly/static/lib/ojdbc8-12.2.0.1.jar > 6. ./hugegraph-hubble/hubble-dist/assembly/travis/jacocoagent.jar > 7. ./hugegraph-hubble/hubble-dist/assembly/travis/jacococli.jar > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
