Hi, +1 (binding) but more work is needed here.
I would be -1 (binding) from me if this didn’t use the WIP disclaimer. The software includes code under the MPL licence which can’t be in a source release [1], the ManyPixels license (likely category X) and your NOTICE and LICENSE files need work. Also note that licenses may change over time, so I’d avoid using URLs to point to them. It is also unclear to me where the software mentioned in LICENSE is bundled in the source release. The LICENSE file needs reflect the contents of the source release and only mention software that is bundled within it. [2] I checked: - incubating in name - signatures and hashes are fine - DISCLAIMER exists - In LICENSE there is no need to repeat the ASF license text - In LICENSE the ManyPixels license doesn’t seem to be compatible with the ALv2 as it it places restricts on use - In LICENSE the full text of bundled 3rd party software needs to be included - NOTICE repeats Information from LICENSE there is no need to do this - It is unclear how these files are licensed [3-22] - No unexpected binary fils - I don’t have a setup for setting if it compiles Kind Regards, Justin 1. https://www.apache.org/legal/resolved.html#category-b 2. https://infra.apache.org/licensing-howto.html#guiding 3. ./config-ui/src/images/icons/copy.svg 4. ./config-ui/src/images/icons/delete.svg 5. ./config-ui/src/images/icons/file.svg 6. ./config-ui/src/images/icons/github.svg 7. ./config-ui/src/images/icons/setting-con.svg 8. ./config-ui/src/images/icons/slack.svg 9. ./config-ui/src/images/icons/sync.svg 10. ./config-ui/src/images/icons/vector.svg 11. ./config-ui/src/images/integrations/azure.svg 12. ./config-ui/src/images/integrations/bitbucket.svg 13. ./config-ui/src/images/integrations/gitee.svg 14. ./config-ui/src/images/integrations/incoming-webhook.svg 15../config-ui/src/images/integrations/zentao.svg 16. ./config-ui/src/plugins/webook/assets/icon.svg 17. ./config-ui/src/plugins/zentao/assets/icon.svg 18. ./grafana/img/github.svg 19. ./grafana/img/gitlab.svg 20. ./grafana/img/jenkins.svg 21. ./grafana/img/jira.svg 22. ./grafana/img/tapd.svg --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
