Hi Justin,
Thanks for your review, we'll fix the problems you mentioned.
Following are our solutions, if anything is wrong please let us know.
1. [1] is copied and modified from Apache spark[2], we didn't
modify the headers. We'll add this information to the LICENSE file in
the source package, just like spark does[3]. We checked that there is
no other 3rd party code in the release.
2. The license header in [4] is a mistake, we will replace it with
Apache License 2.0.
Thanks,
Ethan Feng
[1]
./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
[2]
https://github.com/apache/spark/blob/v3.1.1/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java
[3] https://github.com/apache/spark/blob/v3.1.1/LICENSE
[4]
./common/src/main/java/org/apache/celeborn/common/network/server/memory/ReadBufferListener.java
Justin Mclean <jus...@classsoftware.com> 于2023年1月24日周二 11:03写道：
>
> HI,
>
> Sorry it’s -1 (binding) form me as it contain 3rd party code that is not
> mentioned in LICENSE.
>
> I checked:
> - incubating in name
> - signatures and hashes are file
> - LICENSE is missing license for 3rd party code [1] (this file probably
> incorrect has an ASF header as well) [2]. Is there any other 3rd party code
> in the release?
> - NOTICE is OK (but may need additional text if those 3rd party bits of code
> include a NOTICE file)
> - All files have ASF headers
> - No unexpected binary files
> - Can compile from source
>
> Kind Regards,
> Justin
>
> 1.
> ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
> 2.
> ./common/src/main/java/org/apache/celeborn/common/network/server/memory/ReadBufferListener.java
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
