It depends, if you wrote the codes of `AssertUtils.scala` from scratch without referencing the Spring's Assert class, you can definitely said it's your own work and your own IP, but if you copied the content from Spring's, and converted it into Scala, even with some modifications, I still consider it's originated from Spring project.
And the most important thing is that, you listed it in the LICENSE file and admit that it's copied from Spring project. If you don't agree it's copied from the Spring project, you should remove it from the LICENSE file, but I don't think that's the case. P.S. Sorry, I know it's me who raised this issue in the previous RC vote, if you think that file is not copied from Spring project, you could clarify it and I'd be happy to turn my vote into +1 when convinced. > On Feb 13, 2023, at 15:28, Huajie Wang <benj...@apache.org> wrote: > > Thanks for your review and feedback, we will fix this issue, but I > have a question: > > As we all know, spring is developed in java language, while > Streampark's AssertUtils.scala[1] is developed in scala. As you can > see, the methods and logic in it are very simple. Even if the logic > and method names in AssertUtils.scala are the same as in spring, it > cannot be said that AssertUtils.scala is copied from spring's code. In > other words, I implemented it in another language, like .net. Can you > tell me that I copied the code? I don't know how this part is defined > in ASF? > > [1] > streampark-common/src/main/scala/org/apache/streampark/common/util/AssertUtils.scala > > > Best, > Huajie Wang > > > > kezhenxu94 <kezhenx...@apache.org> 于2023年2月13日周一 14:48写道： > >> Hi, -1 (binding), you cannot change the license header of a third-party's >> file[1] as you mentioned in LICENSE it's from Spring team[2]. >> >> [1] >> streampark-common/src/main/scala/org/apache/streampark/common/util/AssertUtils.scala >> [2] https://github.com/spring-projects/spring-framework >> >>> On Feb 10, 2023, at 17:44, Huajie Wang <benj...@apache.org> wrote: >>> >>> Hello Incubator Community: >>> >>> This is a call for a vote to release Apache StreamPark(Incubating) >>> version 2.0.0-RC6 >>> >>> The Apache StreamPark community has voted on and approved a proposal to >>> release >>> Apache StreamPark(Incubating) version 2.0.0-RC6 >>> >>> We now kindly request the Incubator PMC members review and vote on this >>> incubator release. >>> >>> Apache StreamPark, Make stream processing easier! easy-to-use streaming >>> application development framework and operation platform. >>> >>> >>> StreamPark community vote thread: >>> https://lists.apache.org/thread/lvpc2hywbkdlvkpmjm0knchyk6vhvmnl >>> >>> Vote result thread: >>> https://lists.apache.org/thread/y77vc8c3d5x7wtslm99jydgwmp10ypxv >>> >>> >>> The release candidate: >>> https://dist.apache.org/repos/dist/dev/incubator/streampark/2.0.0-RC6/ >>> >>> Git tag for the release: >>> https://github.com/apache/incubator-streampark/releases/tag/v2.0.0-rc6 >>> >>> Release notes: >>> https://streampark.apache.org/download/release-note/2.0.0/ >>> >>> Maven artifacts are available in a staging repository at: >>> >> https://repository.apache.org/content/repositories/orgapachestreampark-1009/ >>> >>> The artifacts signed with PGP key [5AE01B8E], corresponding to [ >>> benj...@apache.org], that can be found in keys file: >>> https://downloads.apache.org/incubator/streampark/KEYS >>> >>> >>> Last commit hash: >>> •apache-streampark-2.0.0-incubating-src.tar.gz: >>> >> 91083d97727e302997ae35e54e583340101d2e88968495b78fae16c32a0bd47dc0b87aa285f2a6279758906b811ca6665fb2b0120ebbb6d8d41a4da1263bca23 >>> >>> >>> • apache-streampark_2.11-2.0.0-incubating-bin.tar.gz: >>> >> e055643a1657cd4f4dd1352d22bdafd9b3dd2cece5698f503e2a46bd8c1ad6d1a559e2c1041b528b65701f268ba0ae2aefc9072c9a1b0c783fc45c91ec2e88f9 >>> >>> >>> • apache-streampark_2.12-2.0.0-incubating-bin.tar.gz: >>> >> 0fbccc5f3fec8c997fea61d60a399f69ab60abfa21e00a07d7bfce92773ef1a19780c3d639e8411b0ac8891f388ed62ff9b437bfec6c7bfcea3f5debbc98be88 >>> >>> In this vote we fixed RC4,RC5 vote process issue, and some licenses >> issues >>> mentioned in RC3 vote process: >>> https://github.com/apache/incubator-streampark/pull/2277 >>> >>> >>> The vote will be open for at least 72 hours or until the necessary number >>> of votes are reached. >>> >>> Please vote accordingly: >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> More detailed checklist please refer: >>> • >>> >> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist >>> >>> Steps to validate the release， Please refer to: >>> • https://www.apache.org/info/verification.html >>> • https://streampark.apache.org/community/release/how-to-verify >>> >>> >>> How to Build: >>> >>> 1) clone source code: >>>> git clone -b v2.0.0-rc6 g...@github.com:apache/incubator-streampark.git >>> >>> 2) build project: >>>> cd incubator-streampark && sh ./build.sh >>> >>> >>> Thanks, >>> >>> On behalf of Apache StreamPark(Incubating) community >>> >>> >>> Best, >>> Huajie Wang >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
