+CC @Justin Mclean, and @Willem Jiang since you left the concerns It looks like Spark may have incorrectly added that header. You could ask > them why it was added perhaps or just leave it as is. > Kind Regards, > Justin >
I have the same question as Justin asked, do we need to add the ASF License > header to this file[1]? [1] > ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java Willem Jiang Thanks, Cheng Pan On Mar 1, 2023 at 15:04:52, Dongjoon Hyun <dongjoon.h...@gmail.com> wrote: > Since both license headers are Apache License 2.0, we don't see any issue > there. They are compatible. > > The first line of the second license header means the file was copied from > Google Guava project originally. > > Apache Spark community keeps the original header because it has > `Authorship` part, `Copyright (C) 2007 The Guava Authors`. > > /* > * Based on LimitedInputStream.java from Google Guava > * > * Copyright (C) 2007 The Guava Authors > * > * Licensed under the Apache License, Version 2.0 (the "License"); > * you may not use this file except in compliance with the License. > * You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ > > Dongjoon. > > > > On Tue, Feb 28, 2023 at 10:27 PM Ethan Feng <ethanf...@apache.org> wrote: > >> Hi developers, >> I have been running a release in project celeborn(incubating) >> recently and the incubator PPMCs have arguments[2] about the headers >> in source file[1] that we copied from the Spark source. >> We don't understand why the source file[1] has two headers with >> different copyright disclaimers. Could you explain why the source >> file[1] needs two headers? >> >> Regards, >> Ethan Feng >> >> --------------------------------------------------------------------- >> 1. org/apache/spark/network/util/LimitedInputStream.java >> 2. https://lists.apache.org/thread/q8hchs4n2twhjl0qf3rn0ln0hyrvrnnp >> >> --------------------------------------------------------------------- >> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >> >>
