Hi, Sorry, but it -1 binding from me, LICENSE and NOTICE need to be corrected and the lease artefacts need incubating in the name.
I checked: - “incubating" is not in the release name - signatures and hash are fine - LICENSE and NOTICE are not correct, LICENSE information goes in LICENSE not NOTICE and there is no need to list BSD or MIT licenses. Also the license text needs to be included not URLs. (Content at URLs can change or move or be removed). - Note " Apache-2.0 WITH LLVM-exception” is not listed at a Category A license - NOTICE also includes licenses that are not Category A and are not allowed to be included in a source release. - It also looks like the NOTICE file is listing dependencies. You only need to include what is bundled in the release, not the licenses of all dependencies. It is unclear if any 3rd party software is contained in the source release. - Where did these files come from, and how are they licensed?[1][2][3] - No unexpected binary fines - please include instructions on how t build the software in your release. Kind Regards, Justin 1. /website/static/img/undraw_adventure.svg 2. ./website/static/img/undraw_i_can_fly.svg 3. ./website/static/img/undraw_outer_space.svg > On 20 May 2023, at 12:48 am, Willem Jiang <willem.ji...@gmail.com> wrote: > > The LICENSE file communicates the licensing of all content in an > Apache product distribution. > It always contains the text of the Apache License and sometimes more > information.[1] > NOTICE file is used for required third-party notices [2]。 > If we do the source release， we only include the bundled third-party > license in the License file. > Please take a look at StreamPark Source License[3] as an example。 > > [1]https://infra.apache.org/licensing-howto.html > [2]https://infra.apache.org/licensing-howto.html#mod-notice > [3]https://github.com/apache/incubator-streampark/blob/dev/LICENSE > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Fri, May 19, 2023 at 10:14 PM tison <wander4...@gmail.com> wrote: >> >>> These License information should be put into the License file. >> >> Any requirement for this statement? >> >> In ASF projects I involve, I always put dependencies info in the NOTICE >> file and leave the LICENSE file AS IS from >> https://apache.org/licenses/LICENSE-2.0.txt. >> >> Best, >> tison. >> >> >> Willem Jiang <willem.ji...@gmail.com> 于2023年5月19日周五 22:03写道： >> >>> I checked the NOTICE file, it includs the third-party dependencies >>> license information. >>> These License information should be put into the License file. >>> Some third-party dependency Licenses are Apache or MIT, we can choose >>> Apache License by default. >>> >>> I cannot find how to build from the README.md file in the root >>> directory. Did I miss something? >>> >>> >>> Willem Jiang >>> >>> Twitter: willemjiang >>> Weibo: 姜宁willem >>> >>> On Wed, May 17, 2023 at 12:14 PM Xuanwo <xua...@apache.org> wrote: >>>> >>>> Hello Incubator PMC, >>>> >>>> The Apache OpenDAL community has voted and approved the release of Apache >>>> OpenDAL(incubating) 0.34.0-rc1. We now kindly request the IPMC members >>>> review and vote for this release. >>>> >>>> OpenDAL is a data access layer that allows users to easily and >>> efficiently >>>> retrieve data from various storage services in a unified way. >>>> >>>> OpenDAL community vote thread: >>>> >>>> https://lists.apache.org/thread/nh80zh9y11frx7ls9fn4dvj1hdh2n4pb >>>> >>>> Vote result thread: >>>> >>>> https://lists.apache.org/thread/hjkxdvqr1dsrq71cr6j7ltjxvwmn0jg2 >>>> >>>> The release candidate: >>>> >>>> https://dist.apache.org/repos/dist/dev/incubator/opendal/0.34.0-rc1/ >>>> >>>> This release has been signed with a PGP available here: >>>> >>>> https://downloads.apache.org/incubator/opendal/KEYS >>>> >>>> Git branch for the release: >>>> >>>> https://github.com/apache/incubator-opendal/tree/release-0.34.0-rc1 >>>> >>>> Please download, verify, and test. >>>> >>>> The VOTE will pass after got 3 binding approve. >>>> >>>> [ ] +1 approve >>>> [ ] +0 no opinion >>>> [ ] -1 disapprove with the reason >>>> >>>> To learn more about apache opendal, please see >>> https://opendal.apache.org/ >>>> >>>> Checklist for reference: >>>> >>>> [ ] Download links are valid. >>>> [ ] Checksums and signatures. >>>> [ ] LICENSE/NOTICE files exist >>>> [ ] No unexpected binary files >>>> [ ] All source files have ASF headers >>>> [ ] Can compile from source >>>> >>>> More detailed checklist please refer to: >>>> https://github.com/apache/incubator-opendal/tree/main/scripts >>>> >>>> To compile from source, please refer to: >>>> https://github.com/apache/incubator-opendal/blob/main/CONTRIBUTING.md >>>> >>>> Thanks >>>> >>>> Xuanwo >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
