> 2. Meanwhile, why the website is a part of source release? I suggest we can exclude website materials from the source release
> Where is the LICENSE and NOTICE of the binary If we don't make binary releases, what is the policy for bundle their LICENSE or NOTICE? Justin commented the last time (vote for 0.34.0-rc1): > - LICENSE and NOTICE are not correct, LICENSE information goes in LICENSE not NOTICE and there is no need to list BSD or MIT licenses. Also the license text needs to be included not URLs. (Content at URLs can change or move or be removed). > - Note " Apache-2.0 WITH LLVM-exception” is not listed at a Category A license >- NOTICE also includes licenses that are not Category A and are not allowed to be included in a source release. >- It also looks like the NOTICE file is listing dependencies. You only need to include what is bundled in the release, not the licenses of all dependencies. It is unclear if any 3rd party software is contained in the source release. Note the last sentence that "You only need to include what is bundled in the release" and no source code from other party is bundled in OpenDAL's source release. Best, tison. Sheng Wu <wu.sheng.841...@gmail.com> 于2023年6月5日周一 22:27写道： > Hi > > -1 binding > > 1. (The resonse of -1) Unexpected images showing up > > > website/blog/2023-03-16-opendal-entered-apache-incubator/opendal-entered-apache.png > This image includes a vendor logo, I don't think the ASF is granted to > use that as a part of distribution. > > 2. Meanwhile, why the website is a part of source release? > 3. Where is the LICENSE and NOTICE of the binary? We could choose to > don't distribute binary tar, but we should make the LICENSEs of > dependencies clear. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > Willem Jiang <willem.ji...@gmail.com> 于2023年6月5日周一 22:04写道： > > > > +1. Here is what I checked: > > - The checksums and signatures are validated. > > - The LICENSE and NOTICE files look good to me. > > - There is a DISCLAIMER file about incubating. > > - No binary files in the source release > > - I can build the binary from the source kit. > > > > Willem Jiang > > > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Mon, Jun 5, 2023 at 9:54 PM Xuanwo <xua...@apache.org> wrote: > > > > > > > NOTE: README.md does not include `how to build.` > > > > > > Thanks for your NOTE! We have included the instructions on how to > build in our Contributing Guide. We will ensure that this is made clearer > in future updates. > > > > > > On Mon, Jun 5, 2023, at 21:41, Xiaoqiao He wrote: > > > > +1(binding) > > > > > > > > [x] Download links are valid. > > > > [x] Checksums and PGP signatures are valid. > > > > [x] LICENSE files exist. > > > > [x] NOTICE is included. > > > > [x] DISCLAIMER is included. > > > > [x] Source code artifacts have correct names matching the current > release. > > > > [x] All source files have license headers if necessary. > > > > [x] Checked no binary files in source package. > > > > > > > > NOTE: README.md does not include `how to build.` (Which Willem was > > > > concerned about last round.). I try to compile from source with > `cargo > > > > build` > > > > (From tison mentioned above), it works well. IMO it is not a blocker > issue. > > > > > > > > Best Regards, > > > > - He Xiaoqiao > > > > > > > > > > > > On Sun, Jun 4, 2023 at 6:48 AM tison <wander4...@gmail.com> wrote: > > > > > > > >> +1 (binding) > > > >> > > > >> I checked - > > > >> > > > >> [x] Download links are valid. > > > >> [x] Checksums and signatures. > > > >> [x] + incubating in artifacts name > > > >> [x] LICENSE/NOTICE files exist + DISCLAIMER exists > > > >> [x] No unexpected binary files > > > >> [x] All source files have ASF headers > > > >> [x] Can compile from source - with `cargo build' > > > >> > > > >> Best, > > > >> tison. > > > >> > > > >> > > > >> Xuanwo <xua...@apache.org> 于2023年6月3日周六 19:50写道： > > > >> > > > >> > Hello Incubator PMC, > > > >> > > > > >> > The Apache OpenDAL community has voted and approved the release > of Apache > > > >> > OpenDAL(incubating) 0.36.0-rc1. We now kindly request the IPMC > members > > > >> > review and vote for this release. > > > >> > > > > >> > OpenDAL is a data access layer that allows users to easily and > > > >> efficiently > > > >> > retrieve data from various storage services in a unified way. > > > >> > > > > >> > OpenDAL community vote thread: > > > >> > > > > >> > https://lists.apache.org/thread/c211gqq2yl15jbxqk4rcnq1bdqltjm5l > > > >> > > > > >> > Vote result thread: > > > >> > > > > >> > https://lists.apache.org/thread/xk5myl10mztcfotn59oo59s4ckvojds6 > > > >> > > > > >> > The release candidate: > > > >> > > > > >> > > https://dist.apache.org/repos/dist/dev/incubator/opendal/0.36.0-rc1/ > > > >> > > > > >> > This release has been signed with a PGP available here: > > > >> > > > > >> > https://downloads.apache.org/incubator/opendal/KEYS > > > >> > > > > >> > Git branch for the release: > > > >> > > > > >> > > https://github.com/apache/incubator-opendal/tree/release-0.36.0-rc1 > > > >> > > > > >> > Please download, verify, and test. > > > >> > > > > >> > The VOTE will pass after got 3 binding approve. > > > >> > > > > >> > [ ] +1 approve > > > >> > [ ] +0 no opinion > > > >> > [ ] -1 disapprove with the reason > > > >> > > > > >> > To learn more about apache opendal, please see > > > >> https://opendal.apache.org/ > > > >> > > > > >> > Checklist for reference: > > > >> > > > > >> > [ ] Download links are valid. > > > >> > [ ] Checksums and signatures. > > > >> > [ ] LICENSE/NOTICE files exist > > > >> > [ ] No unexpected binary files > > > >> > [ ] All source files have ASF headers > > > >> > [ ] Can compile from source > > > >> > > > > >> > More detailed checklist please refer to: > > > >> > https://github.com/apache/incubator-opendal/tree/main/scripts > > > >> > > > > >> > To compile from source, please refer to: > > > >> > > https://github.com/apache/incubator-opendal/blob/main/CONTRIBUTING.md > > > >> > > > > >> > Thanks > > > >> > > > > >> > Xuanwo > > > >> > > > > >> > > --------------------------------------------------------------------- > > > >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > >> > For additional commands, e-mail: > general-h...@incubator.apache.org > > > >> > > > > >> > > > > >> > > > > > > -- > > > Xuanwo > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
