Hi Justin - Thanks for the review!
Given that this is the first release since the reboot of the community, I am wondering whether these really have to be blockers. We can file JIRAs for each of those issues and address them in the next release. These aren't regressions after all and there have been 7 or 8 releases prior. Thanks again! --larry On Fri, Aug 4, 2023 at 10:43 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > -1 (binding) as well as the Category X license issues with the binaries, > LICENSE is missing a 3rd party licenses which may not be compatible with > the ALv2. > > Note that the font and NOTICE file issue have been brought up before. > > I checked: > - incubating in name > - signatures and hashes are correct > - LICENSE is missing LICENSE for [1][2] however the standard license is > not compatible with the ALv2 one [3]. How is this licensed? > - NOTICE is OK, but please do not use "Copyright 2018 and onwards”. > - you may wan to update your copyright in [4] > - all files have ASF headers > - no unexpected binary file > - can compile from source > > Kind Regards, > Justin > > 1. > ./server/src/main/resources/org/apache/livy/server/ui/static/fonts/glyphicons-halflings-regular.* > 2. > ./docs/assets/themes/apache/bootstrap/fonts/glyphicons-halflings-regular.* > 3. https://www.glyphicons.com/license/ > 4. ./docs/_includes/themes/apache/footer.html > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
