+1 binding

Checked sigs and sums: Matched
LICENSE and NOTICE: Looked fine
DISCLAIMER: In place
Built from src:
  'mvn clean install -DskipTests', with AdoptOpenJDK-11.0.11+9, passed

There is no guideline in the README.md about how to run tests, so I
just tried to run 'mvn test' and it finally failed with failures in
paimon-core module

[ERROR]   CompactionTaskSerializerTest.testCompactionTaskSerializer:42
expected: CompactionTask {partition =
org.apache.paimon.data.BinaryRow@ee18d2a5, compactBefore = [{1, 0, 1,
org.apache.paimon.data.BinaryRow@ee18d2a5,
org.apache.paimon.data.BinaryRow@ee18d2a5,
org.apache.paimon.stats.BinaryTableStats@5f146c05,
org.apache.paimon.stats.BinaryTableStats@5f146c05, 0, 1, 0, 0, [],
2023-09-03T23:05:52.736}, {2, 0, 1,
org.apache.paimon.data.BinaryRow@ee18d2a5,
org.apache.paimon.data.BinaryRow@ee18d2a5,
org.apache.paimon.stats.BinaryTableStats@5f146c05,
org.apache.paimon.stats.BinaryTableStats@5f146c05, 0, 1, 0, 0, [],
2023-09-03T23:05:52.736}], compactAfter = []}
 but was: CompactionTask {partition =
org.apache.paimon.data.BinaryRow@ee18d2a5, compactBefore = [{1, 0, 1,
org.apache.paimon.data.BinaryRow@ee18d2a5,
org.apache.paimon.data.BinaryRow@ee18d2a5,
org.apache.paimon.stats.BinaryTableStats@5f146c05,
org.apache.paimon.stats.BinaryTableStats@5f146c05, 0, 1, 0, 0, [],
2023-09-03T23:05:52.736314}, {2, 0, 1,
org.apache.paimon.data.BinaryRow@ee18d2a5,
org.apache.paimon.data.BinaryRow@ee18d2a5,
org.apache.paimon.stats.BinaryTableStats@5f146c05,
org.apache.paimon.stats.BinaryTableStats@5f146c05, 0, 1, 0, 0, [],
2023-09-03T23:05:52.736334}], compactAfter = []}
[ERROR]   SplitTest.testSerializer:59
expected: org.apache.paimon.table.source.DataSplit@d32c7ba8
 but was: org.apache.paimon.table.source.DataSplit@5623aee8
[INFO]
[ERROR] Tests run: 1214, Failures: 7, Errors: 0, Skipped: 0

Not sure if this is just an environment problem for me. Anyway, better
to include an section about how to test the project in the README.

Thanks.

Mingyu Chen <morning...@163.com> 于2023年9月3日周日 18:36写道:
>
> +1 non-binding.
> I checked:
> [x] Download links are valid.
> [x] Checksums and signatures.
> [x] LICENSE/NOTICE files exist
> [x] No unexpected binary files
> [ ] All source files have ASF headers
> [ ] Can compile from source
>
>
>
> --
>
> Best Regards
> Mingyu Chen
>
> Email:
> morning...@apache.org
>
>
>
>
>
> At 2023-08-29 19:29:16, "Jingsong Li" <jingsongl...@gmail.com> wrote:
> >Hello Incubator PMC,
> >
> >The Apache Paimon community has voted and approved the release of
> >Apache Paimon(incubating) 0.5.0-incubating rc1. We now kindly request
> >the IPMC members review and vote for this release.
> >
> >Apache Paimon(incubating) is a streaming data lake platform that
> >supports high-speed data ingestion, change data tracking and efficient
> >real-time analytics.
> >
> >Paimon community vote thread:
> >
> >https://lists.apache.org/thread/5ftgl4dkjwlyrlc0hkcbzz3c4m6rss62
> >
> >Vote result thread:
> >
> >https://lists.apache.org/thread/x5tnf1359jprlr61pc67s0crs7xg7po5
> >
> >The official Apache source release to be deployed to dist.apache.org:
> >
> >https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.5.0-incubating-rc1/
> >
> >This source release has been signed with a PGP available here (Apache
> >ID: lzljs3620320):
> >
> >https://downloads.apache.org/incubator/paimon/KEYS
> >
> >All artifacts to be deployed to the Maven Central Repository:
> >
> >https://repository.apache.org/content/repositories/orgapachepaimon-1028/
> >
> >Git branch for the release:
> >
> >https://github.com/apache/incubator-paimon/tree/release-0.5.0-incubating-rc1
> >
> >Please download, verify, and test.
> >
> >The VOTE will pass after 3 binding approve.
> >
> >[ ] +1 approve
> >[ ] +0 no opinion
> >[ ] -1 disapprove with the reason
> >
> >To learn more about apache paimon, please see https://paimon.apache.org/
> >
> >Checklist for reference:
> >
> >[ ] Download links are valid.
> >[ ] Checksums and signatures.
> >[ ] LICENSE/NOTICE files exist
> >[ ] No unexpected binary files
> >[ ] All source files have ASF headers
> >[ ] Can compile from source
> >
> >Best,
> >Jingsong
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> >For additional commands, e-mail: general-h...@incubator.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to