Hi PJ and Yu, Thanks for the careful checking and suggestions. I've opened [1] to track the issue and we will resolve it in the next release, if you also don't think this is a release blocker.
[1] https://github.com/apache/incubator-paimon/issues/2413 Best, Jingsong On Wed, Nov 29, 2023 at 8:33 AM Yu Li <car...@gmail.com> wrote: > > I agree that the current organization of the jar is a little bit confusing. > It would be better to keep a single META-INF directory at the root level, and > introduce no additional "paimon-plugin-s3" directory in the dir tree. > > @Jingsong Li and team: please take a look here and open an issue to > track/resolve it if you also find this reasonable, or let us know your > thoughts if I miss anything. > > Best Regards, > Yu > > > On Wed, 29 Nov 2023 at 03:08, PJ Fanning <fannin...@gmail.com> wrote: >> >> I've also never seen the multi-release classes in a dir like >> paimon-plugin-s3/META-INF/versions/ - I've only ever seen them in >> META-INF/versions dir (ie no paimon-plugin-s3 dir in the dir tree). >> >> On Tue, 28 Nov 2023 at 20:03, PJ Fanning <fannin...@gmail.com> wrote: >> > >> > Why is there a META-INF dir and a paimon-plugin-s3/META-INF dir with >> > revival license files? >> > >> > I must admit to finding this confusing. Is there any way to only have >> > one META-INF dir. Most people expect META-INF at the root level - so >> > if we consolidate the 2 META-INF dirs then I'd prefer if the root >> > level one is the one that is kept. >> > >> > On Tue, 28 Nov 2023 at 15:50, Yu Li <car...@gmail.com> wrote: >> > > >> > > Hi PJ, >> > > >> > > Thanks for the notice. >> > > >> > > It seems to me that in the META-INF/NOTICE file bundled in the >> > > paimon-s3-0.6.0-incubating.jar files, there're license disclaimers about >> > > the dependencies, with references to the location of the relative license >> > > file (under the nested "licenses" directory), such as: >> > > ------------- >> > > >> > > This project bundles the following dependencies under BSD-2 License ( >> > > https://opensource.org/licenses/BSD-2-Clause). >> > > >> > > You find it under licenses/LICENSE.dnsjava. >> > > >> > > ... >> > > >> > > This project bundles the following dependencies under the MIT ( >> > > https://opensource.org/licenses/MIT) >> > > >> > > You find them under licenses/LICENSE.checker-framework-qualifiers and >> > > licenses/LICENSE.animal-sniffer. >> > > >> > > ... >> > > >> > > This project bundles the following dependencies under the CDDL 1.1 >> > > license. >> > > >> > > You find it under licenses/LICENSE.jaxb. >> > > >> > > ... >> > > ------------- >> > > >> > > I happen to know this since I noticed similar issues and asked the team >> > > to >> > > resolve them in release 0.4.0 [1], so just for your information. >> > > >> > > Since I haven't completed checking this rc yet, it's possible that there >> > > are newly introduced dependencies in the paimon-filesystems module >> > > (especially the paimon-s3 and paimon-s3-impl sub-modules). Would you mind >> > > further checking it and let us know the detailed dependency with license >> > > (notice/file) missing? Thanks. >> > > >> > > And I will also check this carefully when time allows. >> > > >> > > Best Regards, >> > > Yu >> > > >> > > [1] >> > > https://github.com/apache/incubator-paimon/pull/1067#issuecomment-1537338118 >> > > >> > > On Tue, 28 Nov 2023 at 18:10, PJ Fanning <fannin...@gmail.com> wrote: >> > > >> > > > There is a META-INF/DEPENDENCIES file in >> > > > paimon-s3-0.6.0-incubating.jar but it lists only a small fraction of >> > > > the external jars that are bundled into >> > > > paimon-s3-0.6.0-incubating.jar. >> > > > >> > > > On Tue, 28 Nov 2023 at 11:05, PJ Fanning <fannin...@gmail.com> wrote: >> > > > > >> > > > > I had a look at this jar: >> > > > > >> > > > > >> > > > https://repository.apache.org/content/repositories/orgapachepaimon-1029/org/apache/paimon/paimon-s3/0.6.0-incubating/paimon-s3-0.6.0-incubating.jar >> > > > > >> > > > > It has a META-INF/LICENSE file but this file is a generic ASF license >> > > > > and has no details about all the non-ASF classes that are bundled in >> > > > > the jar. >> > > > > >> > > > > The META-INF/NOTICE likewise does not mention anything about the >> > > > > non-ASF classes. >> > > > > >> > > > > >> > > > > On Mon, 27 Nov 2023 at 04:04, Jingsong Li <jingsongl...@gmail.com> >> > > > wrote: >> > > > > > >> > > > > > Hello Incubator PMC, >> > > > > > >> > > > > > The Apache Paimon community has voted and approved the release of >> > > > > > Apache Paimon(incubating) 0.6.0-incubating rc1. We now kindly >> > > > > > request >> > > > > > the IPMC members review and vote for this release. >> > > > > > >> > > > > > Apache Paimon(incubating) is a streaming data lake platform that >> > > > > > supports high-speed data ingestion, change data tracking and >> > > > > > efficient >> > > > > > real-time analytics. >> > > > > > >> > > > > > Paimon community vote thread: >> > > > > > >> > > > > > https://lists.apache.org/thread/fvzljoyokvs0dp6d24wwvtgdmrczfb3j >> > > > > > >> > > > > > Vote result thread: >> > > > > > >> > > > > > https://lists.apache.org/thread/3gsgkk9n0mpmw98f7y2wyfog0pgc58xc >> > > > > > >> > > > > > The official Apache source release to be deployed to >> > > > > > dist.apache.org: >> > > > > > >> > > > > > >> > > > https://dist.apache.org/repos/dist/dev/incubator/paimon/paimon-0.6.0-incubating-rc1/ >> > > > > > >> > > > > > This source release has been signed with a PGP available here >> > > > > > (Apache >> > > > > > ID: lzljs3620320): >> > > > > > >> > > > > > https://downloads.apache.org/incubator/paimon/KEYS >> > > > > > >> > > > > > All artifacts to be deployed to the Maven Central Repository: >> > > > > > >> > > > > > >> > > > https://repository.apache.org/content/repositories/orgapachepaimon-1029/ >> > > > > > >> > > > > > Git branch for the release: >> > > > > > >> > > > > > >> > > > https://github.com/apache/incubator-paimon/tree/release-0.6.0-incubating-rc1 >> > > > > > >> > > > > > Please download, verify, and test. >> > > > > > >> > > > > > The VOTE will pass after 3 binding approve. >> > > > > > >> > > > > > [ ] +1 approve >> > > > > > [ ] +0 no opinion >> > > > > > [ ] -1 disapprove with the reason >> > > > > > >> > > > > > To learn more about apache paimon, please see >> > > > https://paimon.apache.org/ >> > > > > > >> > > > > > Checklist for reference: >> > > > > > >> > > > > > [ ] Download links are valid. >> > > > > > [ ] Checksums and signatures. >> > > > > > [ ] LICENSE/NOTICE files exist >> > > > > > [ ] No unexpected binary files >> > > > > > [ ] All source files have ASF headers >> > > > > > [ ] Can compile from source >> > > > > > >> > > > > > Best, >> > > > > > Jingsong >> > > > > > >> > > > > > --------------------------------------------------------------------- >> > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > > > > For additional commands, e-mail: general-h...@incubator.apache.org >> > > > > > >> > > > >> > > > --------------------------------------------------------------------- >> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > > For additional commands, e-mail: general-h...@incubator.apache.org >> > > > >> > > > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
