+1(binding) [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] LICENSE files exist. [x] NOTICE is included. [x] DISCLAIMER is included. [x] Source code artifacts have correct names matching the current release. [x] All source files have license headers if necessary. [x] Use `./scripts/verify.py` to verify and build the core module, it works fine.
One nit but not blocker issue is that README.md does not include `how to build` or `how to build sub-module`. It will be helpful to newbies if include it. Best Regards, - He Xiaoqiao On Sat, Dec 30, 2023 at 9:25 PM Sheng Wu <wu.sheng.841...@gmail.com> wrote: > +1 binding > > 1. Faced the same issue as Tison. MacOS M3 finder extracting doesn't work. > 2. `tav -xvf` works with compiling on MacOS. > 3. LICENSE and NOTICE are there. > 4. gpg signed verified. > 5. sha is there. > > One nit, release managers is using the GPG key for two mail boxes(one > for gmail, the other for apache mail box). This should be fine, but > when I use GPG Keychain UI, it reports signed by gmail only. > This could be confusing. Recommend using a specific GPG key by using > apache mail box for ASF release only. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > tison <wander4...@gmail.com> 于2023年12月29日周五 22:21写道： > > > > +1 (binding) > > > > Thank you Xuanwo. I use macos Finder's extract UI and it fails to > > build. Using `tar -xvf` works. > > > > Best, > > tison. > > > > Xuanwo <xua...@apache.org> 于2023年12月29日周五 22:00写道： > > > > > > Hi, tison > > > > > > The tarball doesn't have `bindings/c` in the `Cargo.toml` > > > > > > ```toml > > > 18 │ [workspace] > > > 19 │ default-members = ["core"] > > > 20 │ exclude = [ > > > 21 │ "examples", > > > 22 │ > > > 23 │ ] > > > 24 │ members = [ > > > 25 │ "core", > > > 26 │ "core/fuzz", > > > 27 │ "core/edge/*", > > > 28 │ "core/benches/vs_*", > > > 29 │ > > > 30 │ "bindings/nodejs", > > > 31 │ "bindings/python", > > > 32 │ "bindings/java", > > > 33 │ > > > 34 │ > > > 35 │ ] > > > 36 │ resolver = "2" > > > ``` > > > > > > We used to met dirty cache issues on other platforms. Would you like > to double check it? > > > > > > Use `tar -xvf` to extract the tarball instead of using a system > decompression application. > > > > > > On Fri, Dec 29, 2023, at 16:30, tison wrote: > > > > -1 binding > > > > > > > > + Download links valid > > > > + GPG sign correctly > > > > > > > > $ for i in (*.tgz|*.tar.gz|*.nupkg); do echo $i; gpg --verify $i.asc > $i; done > > > > apache-opendal-incubating-0.44.0-src.tar.gz > > > > gpg: Signature made 二 12/26 20:49:34 2023 CST > > > > gpg: using RSA key > 25812FA45EC6D2DDCBE4B6604F43CB2BC2E9EFE5 > > > > gpg: Good signature from "dqhl76 (Identifier for authoring code on > > > > GitHub) <dqh...@gmail.com>" [unknown] > > > > gpg: aka "Liuqing Yue (Apache Committer) > > > > <liuqing...@apache.org>" [unknown] > > > > gpg: WARNING: This key is not certified with a trusted signature! > > > > gpg: There is no indication that the signature belongs to > the owner. > > > > Primary key fingerprint: 2581 2FA4 5EC6 D2DD CBE4 B660 4F43 CB2B > C2E9 EFE5 > > > > > > > > + Checksum matched > > > > + LICENSE and NOTICE exists > > > > > > > > - Cannot build and test Java binding: > > > > > > > > Caused by: > > > > failed to read > > > > > `/Users/tison/Labs/vropendal/apache-opendal-incubating-0.44.0-src/bindings/c/Cargo.toml` > > > > > > > > Caused by: > > > > No such file or directory (os error 2) > > > > > > > > Seems we exclude those directories and it cause build failure. > > > > > > > > Best, > > > > tison. > > > > > > > > Xuanwo <xua...@apache.org> 于2023年12月28日周四 13:14写道： > > > >> > > > >> Carry my non-binding +1 VOTE from the dev@o.a.o > > > >> > > > >> On Thu, Dec 28, 2023, at 13:12, Liuqing Yue wrote: > > > >> > Hello Incubator PMC, > > > >> > > > > >> > The Apache OpenDAL community has voted and approved the release > of Apache > > > >> > OpenDAL(incubating) 0.44.0-rc.1. We now kindly request the IPMC > members > > > >> > review and vote for this release. > > > >> > > > > >> > OpenDAL is a data access layer that allows users to easily and > efficiently > > > >> > retrieve data from various storage services in a unified way. > > > >> > > > > >> > OpenDAL community vote thread: > > > >> > > > > >> > https://lists.apache.org/thread/nycyfc1m6819bj8vsb20vmbnlhs0kbdn > > > >> > > > > >> > Vote result thread: > > > >> > > > > >> > https://lists.apache.org/thread/pfnlmn9vqn1rqdy54wzm3mkx1wnt9mv6 > > > >> > > > > >> > The release candidate: > > > >> > > > > >> > > https://dist.apache.org/repos/dist/dev/incubator/opendal/0.44.0-rc.1/ > > > >> > > > > >> > This release has been signed with a PGP available here: > > > >> > > > > >> > https://downloads.apache.org/incubator/opendal/KEYS > > > >> > > > > >> > Git tag for the release: > > > >> > > > > >> > > https://github.com/apache/incubator-opendal/releases/tag/v0.44.0-rc.1 > > > >> > > > > >> > Maven staging repo: > > > >> > > > > >> > > https://repository.apache.org/content/repositories/orgapacheopendal-1022/ > > > >> > > > > >> > Please download, verify, and test. > > > >> > > > > >> > The VOTE will be open for at least 72 hours and until the > necessary > > > >> > number of votes are reached. > > > >> > > > > >> > [ ] +1 approve > > > >> > [ ] +0 no opinion > > > >> > [ ] -1 disapprove with the reason > > > >> > > > > >> > To learn more about apache opendal, please see > https://opendal.apache.org/ > > > >> > > > > >> > Checklist for reference: > > > >> > > > > >> > [ ] Download links are valid. > > > >> > [ ] Checksums and signatures. > > > >> > [ ] LICENSE/NOTICE files exist > > > >> > [ ] No unexpected binary files > > > >> > [ ] All source files have ASF headers > > > >> > [ ] Can compile from source > > > >> > > > > >> > More detailed checklist please refer to: > > > >> > https://github.com/apache/incubator-opendal/tree/main/scripts > > > >> > > > > >> > To compile from source, please refer to: > > > >> > > https://github.com/apache/incubator-opendal/blob/main/CONTRIBUTING.md > > > >> > > > > >> > Here is python script in release to help you verify the release > candidate: > > > >> > > > > >> > ./scripts/verify.py > > > >> > > > > >> > Thanks > > > >> > > > > >> > Liuqing Yue > > > >> > > > > >> > > --------------------------------------------------------------------- > > > >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > >> > For additional commands, e-mail: > general-h...@incubator.apache.org > > > >> > > > >> -- > > > >> Xuanwo > > > >> > > > >> > --------------------------------------------------------------------- > > > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > >> For additional commands, e-mail: general-h...@incubator.apache.org > > > >> > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > -- > > > Xuanwo > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
