Hi Justin,

Thanks for your feedback, we will change the NOTICE file for future
releases.

Thanks,
Keyong Zhou


Justin Mclean <jus...@classsoftware.com> 于2024年1月5日周五 13:44写道:

> Hi,
>
> +1 (binding)
>
> I checked in the source release:
> - incubating in the name
> - signatures and hashes are fine
> - DISCLAIMER exists
> - LICENSE looks good
> - The NOTICE file needs to be updated and likely does not contain all the
> needed information. For example, The Flink Remote Shuffle Project NOTICE
> file[1] contains:
> This product includes software developed at The Alibaba Group Holding Ltd
> (https://www.alibaba.com/).
> - no unexpected binary files.
> - all files have ASF headers
> - can compile from source
>
> Kind Regards,
> Justin
>
> 1. https://github.com/flink-extended/flink-remote-shuffle/blob/main/NOTICE
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Reply via email to