On Fri, Mar 29, 2024 at 8:41 AM Sheng Wu <wu.sheng.841...@gmail.com> wrote:
> Hi > > Yes, a project doesn't have to separate the repository into two for > both website and source codes, once the license has been reviewed. > Calcite is another TLP, which is guaranteed, so it is on their PMC > oversight. > > My suggestion is based on things that may not be suitable in your > final release, such as logos from other vendors, > https://github.com/dromara/hertzbeat/tree/master/home/static/img/icons. > Those may be available to use on your website, but not available for > source tar. Such as Apple Inc. logo is included currently. > - https://github.com/dromara/hertzbeat/tree/master/home/static/img/icons > - > https://github.com/dromara/hertzbeat/blob/master/home/static/img/icons/ios.svg > > > I don't understand what you're trying to ask the proposed project to do. It seems like you're holding them to a bar that is above what podlings are expected to follow when coming in to even be considered accepted to the ASF. I don't think any of this needs to be resolved before we accept the project, we all know that there's a period between when the project leaves its former home and enters its new home that they are in transition and need to make a large number of changes. None of this blocks acceptance, looks like a great addition +1 from me. John > Sheng Wu 吴晟 > Twitter, wusheng1108 > > Francis Chuang <francischu...@apache.org> 于2024年3月29日周五 15:47写道： > > > > Thanks, Chao Gong, for addressing those issues in > > > https://github.com/dromara/hertzbeat/commit/1284914c4a2d42c8355417c164810787fb64e588 > > > > Looking at the updated website, the issues raised have been taken care > of. > > > > Regarding keeping the website's source code and project code in the > > project repository, I don't think it's 100% necessary to separate the > > website into a separate repository. > > > > For Calcite, our site is in the same repository as our code: > > https://github.com/apache/calcite/tree/main/site > > > > We include the correct licenses in the LICENSE file when we build a > > release, using a template: > > https://github.com/apache/calcite/blob/main/LICENSE > > > > Francis > > > > On 29/03/2024 6:05 pm, Sheng Wu wrote: > > > Some things should be fixed > > > > > > 1. At the top of the home page, <If you like HertzBeat, star us on > > > GitHub⭐️⭐️> exists, this should be removed. > > > 2. At the top menu, <huaweicloud> exists, I don't think this project > > > is Huawei, and please don't use another vendor's brand. > > > 3. Similar with <2>, but for OSPP. That is also another org brand. > > > 4. When I first lands on the homepage, there is a pop up box to ask me > > > star on GitHub. This should be removed too. GitHub repository is just > > > a bi-way synced mirror repository. ASF has its own code repository, > > > which is also the main repository to make sure vendor neutral. > > > > > > A thing you should fix later, your website source codes and resources > > > are in the same repository. Those things may not be able to be > > > included considering the license and binaries(png, videos) may be > > > included. In the ASF, website is usually a separate repository. > > > But the <Git Repositories> in your proposal seems not included. Please > > > reach your mentors and fix the proposal. > > > > > > Sheng Wu 吴晟 > > > Twitter, wusheng1108 > > > > > > Zhang Yonglun <zhangyong...@apache.org> 于2024年3月29日周五 14:24写道： > > >> > > >> Hi Incubator, > > >> > > >> Following the discussion [DISCUSS] Incubating Proposal for > HertzBeat[1], > > >> I am starting this official vote for the HertzBeat project. > > >> > > >> Here is their proposal: > > >> > https://cwiki.apache.org/confluence/display/INCUBATOR/HertzBeatProposal > > >> > > >> Please cast your vote: > > >> > > >> [ ] +1, bring into the Incubator > > >> [ ] +0, I don't care either way > > >> [ ] -1, do not bring HertzBeat into the Incubator, because... > > >> > > >> The vote will open for one week from today. > > >> > > >> [1] https://lists.apache.org/thread/snxcdyvqgvhgjdmfv4l192g9tdf8w7rn > > >> > > >> Best Regards, > > >> Zhang Yonglun > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > >> For additional commands, e-mail: general-h...@incubator.apache.org > > >> > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
