> Quoting Roland Dreier <[EMAIL PROTECTED]>:
> Subject: Re: [PATCH] for-2.6.23 ib/umad: add partition support
>
> > We made a mistake of not validating the offset field otherwise we could
> > have used it, too: as it is I think apps just use "write" so
> > there's a useless byte counter in that field.
>
> which offset field? I don't see the string "offset" anywhere in ib_user_mad.h
static ssize_t ib_umad_write(struct file *filp, const char __user *buf,
size_t count, loff_t *pos)
We could have asked all users to use pwrite with offset 0, and then other I
think pos field would be useful for other things like versioning. As it is,
people use write to pass in MADs, so I'm not sure what does pos point to.
--
MST
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
