You are right. this is not really needed. please use the previous
version of the patch.
On Tue, Sep 30, 2008 at 6:24 AM, Roland Dreier <[EMAIL PROTECTED]> wrote:
> > - handle a case when ipoib_ib_dev_stop() is called twice on the
> > same dev->priv - zero the timer after its deletion.
>
> I don't understand why this is an issue and why:
>
> > + /* Make sure the timer was initialized */
> > + if (priv->poll_timer.function) {
> > + del_timer_sync(&priv->poll_timer);
> > + memset(&priv->poll_timer, 0, sizeof priv->poll_timer);
>
> this memset is needed.
>
> If the timer isn't pending, isn't del_timer_sync() just a no-op? What
> am I missing?
>
> - R.
>
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
