Cameron Harr wrote:
Vladislav Bolkhovitin wrote:
Cameron Harr wrote:
Vladislav Bolkhovitin wrote:
** Sometimes the benchmark "zombied" (process doing no work, but process can't be killed) after running a certain amount of time. However, it wasn't repeatable in a reliable way, so I mark that this particular run has zombied before.
That means that there is a bug somewhere. Usually such bugs are found in few hours of code auditing (srpt driver is pretty simple) or by using kernel debug facilities (example diff to .config attached). I personally always prefer put my effort on fixing real things, not inventing various workarounds, like srpt_thread in this case.

So I would:

  1. Completely remove srpt thread and all related code. It doesn't do
anything, which can't be done in SIRQ context (tasklet)

2. Audit the code to check if it does any action, which it shouldn't do on SIRQ and fix it. This step isn't required, but usually it saves a lot of time of puzzled debugging in the future.

  3. Change in srpt_handle_rdma_comp() and  srpt_handle_new_iu()
SCST_CONTEXT_THREAD to SCST_CONTEXT_DIRECT_ATOMIC.

I'm assuming you didn't want me to implement this change this time, correct?

Seems, I've already done that in the patch you use ;)
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to