> > > + queue_delayed_work(sense->sense_wq , &sense->sense_poll, > > > + round_jiffies(MLX4_SENSE_RANGE));
> > should be round_jiffies_relative, right? > I did not find critical difference between the two: Not sure what you mean by "critical" -- the difference is that one is correct and one is not; since queue_delayed_work() takes a relative timeout rather than an absolute time in jiffies, then round_jiffies_relative() should be used. > > Do we really another work queue, or can we share one queue for the > > catastrophic error and port sensing work? > There is no special reason for having another queue other then convenience. > The catastrophic work queue is defined in catas.c Just make a common thread for both in the most convenient spot and use it. We waste too many kernel threads as it is. - R. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
