Yes, very different from PROPERTY_DEFAULT_REPOSITORIES. I agree that should stay as-is and is very handy. I'll commit my changes by the end of the week after I do some more testing.
Any thoughts to doing a 1.2.3 release so we can get this upstream into SMX? Thanks, Matt On Thu, 16 Dec 2010 00:18:04 +0100, Guillaume Nodet <gno...@gmail.com> wrote: > Sorry, I think i'm a bit off-topic here. > There is a confusing naming between > MavenSettingsImp#DEFAULT_REPOSITORIES and > MavenConfigurationImpl#PROPERTY_DEFAULT_REPOSITORIES which are > completely unrelated. > I was mostly referring to the second one and you to the first one I think. > > So yeah, I think your proposal makes sense as it gives more control > over the actual list of repositories used. > > On Thu, Dec 16, 2010 at 00:12, Guillaume Nodet <gno...@gmail.com> wrote: >> I think having http://osgi.sonatype.org/content/groups/pax-runner as >> the default repositories is wrong. >> I've added the support for default repositories not as "fallback >> repositories" if no config has been provided, but as a list of >> repositories that need to be checked first and take precedence over >> anything else. The main use case was to be able to support snapshots >> in a local repository without having to go online at all, so the idea >> was really to have the DEFAULT_REPOSITORIES be local repositories not >> remote. >> It's a bit different than the local repository which is just another >> repository (albeit local) where new snapshots can be checked in remote >> repositories even if found in the local repo. >> So default repositories is not a default value for repositories. >> >> That's the reason the resolution in Connection#getInputStream() >> actually uses two passes, one for default repositories, the other one >> for all other (local + remote). >> >> On Wed, Dec 15, 2010 at 22:54, Matt Pavlovich <m...@mediadriver.com> >> wrote: >>> All- >>> >>> Another scenario came up that I think should be handled in pax-url-mvn. >>> A >>> scenario where *only* a local repository is used. To support this, I'm >>> proposing removing the DEFAULT_REPOSITORIES notion, moving that repo >>> into >>> the FALLBACK_REPOSITORIES. (Default repo: >>> http://osgi.sonatype.org/content/groups/pax-runner, now would be a part >>> of >>> the FALLBACK_REPOSITORIES) >>> >>> The major change here is that MavenSettingsImpl.getRepositories() would >>> then return 'null', instead of the default repo. That could break >>> things, >>> so I wanted to get feedback from folks before committing anything. >>> >>> Thoughts? >>> >>> Thanks! >>> Matt Pavlovich >>> >>> >>> >>> Scenarios: >>> >>> 1. Local repository only >>> - No repositories specified in settings.xml >>> - Set useFallbackRepositories=false >>> >>> 2. Local repository + Remote repositories >>> - Local repository from settings.xml >>> - Remote repositories from settings.xml >>> - Set useFallbackRepositories=false >>> >>> 3. Local repository + Remote repositories + Fallback repositories >>> - Local repository from settings.xml >>> - Remote repositories from settings.xml >>> - Fallback repositories from >>> org.ops4j.pax.url.maven.commons.MavenSettingsImpl.java >>> - Set useFallbackRepositories=true >>> >>> 4. Any of the above scenarios + ProxySupport >>> - Set proxySuppot=true >>> >>> >>> >>> _______________________________________________ >>> general mailing list >>> general@lists.ops4j.org >>> http://lists.ops4j.org/mailman/listinfo/general >>> >> >> >> >> -- >> Cheers, >> Guillaume Nodet >> ------------------------ >> Blog: http://gnodet.blogspot.com/ >> ------------------------ >> Open Source SOA >> http://fusesource.com >> _______________________________________________ general mailing list general@lists.ops4j.org http://lists.ops4j.org/mailman/listinfo/general