Thanks guys for looking into this. See some comments inline.

On Thu, Sep 1, 2011 at 4:30 AM, Andreas Pieber <[email protected]> wrote:

> Hey Harald,
>
> On Wed, Aug 31, 2011 at 19:36, Harald Wellmann <[email protected]>wrote:
>
>> I did a quick review of the Über-Master [3] and compared the plugin
>> versions with the latest ones on Maven Central. This is what I noticed:
>>
>> (c) The CI URL http://ci.ops4j.org/ is broken. So either this is a
>> redirect you missed in your cleanup, or the entry should be updated
>>
>
> Thanks for pointing me at this; was a minor error in the config. Should
> work now
>

There will be more work in near future, this in a separate mail/thread.


>
> (d) Is the repos.ops4j profile still required? If so, what for?
>>
>
Well, you can deploy to different targets.. we used to have sonatype
staging, sonatype snapshots, ops4j's own repo, ops4j's own snapshot repo.
Sure, the last two can be dropped.

>
> Good question. I don't think so, but we had some discussions about this
> already some time ago: @Toni & @Achim WDYT? IMHO we can remove the goals at
> least since it wasn't about deploying our own artifacts there but rather
> third party artifacts. Right?
>
>
>> (e) Plugin version check:
>>
>> maven-dependency-plugin 2.3 - Cool, we're ahead of
>> http://maven.apache.org/**plugins/index.html<http://maven.apache.org/plugins/index.html>!
>>
>
> funny, because the latest version in m2 is 2.3 :-)
> http://search.maven.org/#search%7Cga%7C1%7Cmaven-dependency-plugin
>
>
>>
>> This is a list of potential updates with the latest versions from Maven
>> Central:
>> maven-jar-plugin 2.3.2
>> maven-release-plugin 2.2.1
>> maven-checkstyle-plugin 2.7
>> wagon-ssh-external 1.0
>> cobertura-maven-plugin 2.5.1
>>
>> maven-javadoc-plugin has 2.8 in <pluginManagement> but 2.6.1 in
>> <reporting>, I'd suggest 2.8 for both.
>>
>
> Oha... *BLUSH* (and done) :-)
>
>
>> (f) I don't see what the ops4j.gpg.use-agent property is for, not even
>> after reading the maven-gpg-plugin docs. Where do you get this agent from,
>> how do you use it, and when do you have to use it?
>>
>
> According to the maven-gpg-plugin docu
> http://maven.apache.org/plugins/maven-gpg-plugin/sign-mojo.html useAgent
> simply activates the --use-agent or --no-use-agent for gpg; --> I think
> http://www.debian-administration.org/article/Using_gnupg-agent_to_securely_retain_keys
>  should
> explain the details. But basically the agent is only an password store -->
> you do not provide your password via your .m2/settings.xml but rather enter
> it only ones during the release process in the console and it is
> automatically re-entered using your agent during the process. Since the
> default-process is to configure the password in your settings.xml our
> default value is false.
>
>
>> (g) For the benefit of all Eclipse/m2e users - including myself ;-)  - I
>> would like to add an org.eclipse.m2e:lifecycle-**mapping section in
>> <pluginManagement> for all plugins defined in the master POM that are not
>> recognized by m2e by default.
>>
> This will guarantee that m2e can import projects into Eclipse without error
>> markers and save users manual configuration. There will be no side-effects
>> on Maven CLI builds or other IDEs.
>>
>
> Since this does not seam to affect any other configs/plugins: Feel free to
> go ahead :-)
>

You may need to get a brainwash in terms of IDEs .. other topic ;)


>
>
>> See [1] for the background and [2] for an example from Pax Exam. I think
>> the master POM is the best place for this to avoid repetitions in individual
>> projects.
>>
>> (h) Does this version already include all the changes you were planning to
>> do to make the next Pax Runner release work more smoothly? If anything is
>> missing, I'm ready to help out...
>>
>
> Thank you very much, but except from your request for the m2e configuration
> everything should be included :-) Once this is in we can go ahead and
> release master-2.0.0.
>

To recap, is master-2.0.0 the only (and flat) parent of ALL ops4j projects ?
I recall to have the distinguishing pax-master to simplify pom managements
 for both: pax projects (inherit from pax-master) and non pax projects
(inherit from ops4j-master).
I think it was about default naming conventions in pax projects as well as
some (maven-) site configuration. This may be obsolete, just keep in mind we
have a big Pax stack but also non Pax projects. Not sure if i missed
important bits of the discussion during my off time.

>
> Thank you very much for your review/feedback!
>
> Kind regards,
> Andreas
>
>
>>
>> Best regards,
>> Harald
>>
>> [1] 
>> http://wiki.eclipse.org/M2E_**plugin_execution_not_covered<http://wiki.eclipse.org/M2E_plugin_execution_not_covered>
>> [2] https://github.com/ops4j/org.**ops4j.pax.exam2/blob/master/**
>> pom/pom.xml<https://github.com/ops4j/org.ops4j.pax.exam2/blob/master/pom/pom.xml>
>> [3] 
>> https://github.com/ops4j/org.**ops4j.master/blob/master/pom.**xml<https://github.com/ops4j/org.ops4j.master/blob/master/pom.xml>
>>
>> Am 31.08.2011 13:39, schrieb Andreas Pieber:
>>
>>  OK, finally in my lunch break I had some time to revisite this:
>>>
>>> (a) currently we have an ueber master AND a pax master [1] I think we
>>> should completely remove it.
>>>
>>> (b) I've refactored great parts of the ueber master and upgraded almost
>>> all versions there --> I think we should upgrade the version to 2.0.0
>>> since the svn/scm parts had been completely removed.
>>>
>>> WDYT?
>>>
>>> Kind regards,
>>> Andreas
>>>
>>> [1] https://github.com/ops4j/org.**ops4j.pax.master/blob/master/**
>>> pom.xml<https://github.com/ops4j/org.ops4j.pax.master/blob/master/pom.xml>
>>>
>>
>> ______________________________**_________________
>> general mailing list
>> [email protected]
>> http://lists.ops4j.org/**mailman/listinfo/general<http://lists.ops4j.org/mailman/listinfo/general>
>>
>
>
> _______________________________________________
> general mailing list
> [email protected]
> http://lists.ops4j.org/mailman/listinfo/general
>
>


-- 
Toni Menzel Source <http://tonimenzel.com>
_______________________________________________
general mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/general

Reply via email to