David Jencks wrote:
-1

scm info is wrong (should end in "trunk")
depends on unreleased parent pom. I'd have no problem voting on both poms together.
Thanks, that's good advise.
So, Vivek: for the next VOTE you might want to make it a combined one so you don't have to wait until the vote for the parent pom has been accepted.


versions are not specified for maven-clean-plugin and maven-compiler-plugin. Are they specified elsewhere?
Since the minimum maven version is specified to be 2.0.9, and maven-2.0.9 actually "pins" these versions, effectively this means these plugins do have an effective/enforced version (maven-clean-plugin-2.2, maven-compiler-plugin-2.0.2).
But specifying (those) versions for these won't harm of course.


Since including non-java files in src/main/java and src/test/java is very bad practice I would prefer to not support it and force any project that does wish to do this to muck up its own pom rather than promoting it with the resource settings in the root pom. However this is not enough for a -1.
Oh, I really overlooked those.
I agree the build/resources and build/testResources elements should not be 
included in such a master pom.
I propose those element simply to be removed.
In addition, I think the eclipse-plugin also is a bit too specific for a master 
pom and maybe should be dropped as well?


As with the portals-pom I'd prefer to see the "review copy" in a nexus staging repo and the actual artifact being voted on in a svn tag.
Thanks again for pointing this out.
Now only where to find proper and currrent guidelines/docs for how to apply the 
nexus release procedures...

Regards,

Ate

thanks
david jencks

On Mar 17, 2009, at 9:23 AM, Randy Watler wrote:

+1

Vivek Kumar wrote:
Hi,

As with the earlier proposed release of the portal-pom for the portals project, we also propose to release an applications-pom for the
applications project.

I'd like to make a release of this parent POM so that we can start referring to a non-SNAPSHOT version,
applications pom is available here for review

http://svn.apache.org/viewvc/portals/applications/applications-pom/trunk/pom.xml?view=markup

Please vote on releasing this version 1.0 of  Applications-pom
POM. The vote is open for the next 72 hours.

  [ ] +1 for Release
  [ ] -1 Don't release, reason

Here's my +1.

Vivek Kumar






Reply via email to