David Jencks wrote:
I played with this a bit while working on the portlet-api poms. It works pretty well however I have some reservations:

1. There is no compiler plugin source level specified. So, if you have code beyond java 1.3, you need to configure the compiler plugin in your pom. I think that portals is all on java 5 and maybe this could be set in the portals-pom directly.
Not all.
For instance the portlet-spec/portlet-api-1.0 needs to be JDK 1.4 compatible.

I don't think it such a big deal to configure the compiler source level per 
project either.
For Portals APA, Pluto and Jetspeed, we only have to set this in each their 
master pom (to Java5 indeed).


2. I don't like the name prepare-release for the profile that uses ianal and rat. First, it doesn't actually prepare anything and is confusingly similar to the release plugin release:prepare goal. Second and more important I think the ianal pllugin should run by default always.
AFAIK, Vivek initially *had* it configured within the apache-release profile so that it would run by default but it caused problems with the release plugin itself (something about tmp files causing trouble).
The name might not be optimal, I agree, but that's something we can adjust in a 
future release.
IMO, this is not something to hold up/stop the release for.

Alternatively the apache-release profile could perhaps be extended to include these plugins.

Also, I suspect there will be an apache 7 pom soon as some work to make the release plugin produce a source distribution more automatically are underway. So it might be worth waiting another couple days to see if this happens.
The vote is already out, so waiting for apache 7 pom would actually mean 
starting a new release for portals-pom-1.2.
While I agree the ideas for the apache 7 pom might help for the source distribution, that probably needs "validating" by itself before we can rely on it to be "proper" for the ASF.
Within the light of our current planned release schedules however I don't want 
to wait on that.


However these are fairly minor quibbles and we could postpone them.
So I gather this means a +1 from you on the current VOTE for portals-pom-1.1, 
even with the above remarks, right?

Regards,

Ate


thanks
david jencks

On May 8, 2009, at 5:12 AM, Vivek Kumar wrote:

Hi all

This new pom now uses the Apache 6 pom as parent which allowed to cleanup and remove many elements.

Furthermore, the Portals developers info has been taken out to be moved to a new main portals-site-pom shortly. That will make it easier to incorporate updates to the developers info without having to change this Portals super pom and thereby effecting all sub projects and their versions.

Please review the release candidate POM from the Nexus staging repository below:

https://repository.apache.org/content/repositories/portals-staging-014/org/apache/portals/portals-pom/1.1/
Please vote on releasing portals-pom-1.1 .

Vote is open for the next 72 hours.

Please cast your vote:

[ ] +1 for Release
[ ]  0  for Don't care
[ ] -1 Don't release, reason

Regards
Vivek Kumar



Reply via email to