I don't like the implementation of this class[1] for two reasons:
1.) There are several if-else's missing curly braces.
2.) Methods setColor(), setFont(), setPaint(), setBackground(), and
clip() quietly just return and rely on the previous values if the caller
provides a NULL argument. It should set the value to NULL instead and
let the NPE occur naturally--that provides the quickest way for the
developer to realize that he or she goofed up. If setFont(NULL) just
relies on the previous value of the font, as it does now, it is much
harder to track the error further downstream in the code. See [2].
Glen
[1]
https://svn.apache.org/repos/asf/xmlgraphics/commons/branches/commons-1_1/src/java/org/apache/xmlgraphics/java2d/GraphicContext.java
[2] http://marc.theaimsgroup.com/?l=fop-dev&m=111596910816787&w=2 (in
retrospect, apologies for the harsh tone).
Jeremias Maerki wrote:
Could anyone please check out the 1.1 branch and throw a second pair of
eyes on the stuff generated by an "ant dist"?
https://svn.apache.org/repos/asf/xmlgraphics/commons/branches/commons-1_1
If everything's ok, I'll tag the branch for 1.1 and upload the
distribution candidates up to people.apache.org so we can vote on the
distribution. Once everything's ok and the vote is good, we can upload
that stuff to the mirror. This is a little different to what we've done
before and it seems to closer mirror the expecation of the ASF
membership concerning the release process. Any objections to this?
Thanks,
Jeremias Maerki
---------------------------------------------------------------------
Apache XML Graphics Project URL: http://xmlgraphics.apache.org/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Apache XML Graphics Project URL: http://xmlgraphics.apache.org/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
