https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
Jeremias Maerki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO --- Comment #3 from Jeremias Maerki <[email protected]> 2011-01-31 15:49:11 EST --- Thanks for the patch, Joshua. Would you mind doing a couple of changes? You've added a few constants to TIFFImageDecoder which are only used in the package o.a.x.image.writer (which is an API package and should not access any implementation packages). I think it would be better to change these constants into an enum in the ...image.writer package. The other one concerns the ImageWriterParams.setOneRowPerStrip(boolean). Wouldn't it make more sense to actually use an integer here? With the boolean the only possible values are 1 and <image-height>. With an integer, one could set 32 rows for a strip, for example. Alternatively, this method could be renamed to setSingleStrip(boolean) (or something like that) essentially inverting the meaning of the boolean. My reasoning: setOneRowPerStrip(false) says "not one row per strip", but setSingleStrip(true) would say "one strip with <image-height> rows" and setSingleStrip(false) would set the internal "Integer rowsPerStrip" to 1, allowing to later add a method setRowsPerStrip(int) if anyone needs that. Please let me know what you think. I'll later take a deeper look again. Thanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
