[ 
https://issues.apache.org/jira/browse/XGC-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544017#comment-13544017
 ] 

Chris Bowditch commented on XGC-76:
-----------------------------------

Hi Rob,

The patch itself looks fine. As Glenn suggested on fop-dev though we could do 
with a layout unit test to cover these changes. I think thats a reasonable 
suggestion since the changes affect layout. Can you attach a patch that adds 
layout unit tests?

Thanks,

Chris
                
> [PATCH] Dependant on FOP-2174 - Change to XGC to support the changes in FOP 
> for image scaling. Scaling by resolution is removed to avoid duplicate 
> scaling.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: XGC-76
>                 URL: https://issues.apache.org/jira/browse/XGC-76
>             Project: XMLGraphicsCommons
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Robert Meyer
>            Assignee: Chris Bowditch
>         Attachments: fop.xconf, output-144-with-xgc-fop-patches.pdf, 
> output-144-wo-xgc-patch.pdf, output-72-wo-xgc-fop-patches.pdf, patch.diff, 
> test.fo
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: general-h...@xmlgraphics.apache.org

Reply via email to