On 29/09/14 19:07, Glenn Adams wrote:
I agree with Luis that we shouldn't intentionally release a version that we
know will fail with 1.7, so I agree it is better to disable the test or put
in a workaround.
Disabling the test is not going to change anything to the fact that the
code will behave differently under Java 1.7 compared to 1.6.
So we can decide to live with it and release anyway —in which case we
might as well leave the test enabled.
Or we decide that we want to hold the release until this issue has been
further investigated. But my availability for doing the release is this
week only; after that I can’t guarantee I will find time again.
So, what do we decide?
Vincent
On Mon, Sep 29, 2014 at 10:08 AM, Vincent Hennebert <[email protected]>
wrote:
On 29/09/14 00:00, Luis Bernardo wrote:
+1
There is a unit test that fails with jdk1.7+ but passes with 1.6. The
test is
testICCProfiles(org.apache.xmlgraphics.image.loader.ImageLoaderTestCase).
I think that should be addressed, even if it means removing the test, and
then
the release can be done.
There’s actually already an issue logged about this:
https://issues.apache.org/jira/browse/XGC-66
I added a comment to it. I don’t believe that should delay the release,
though, since we are targeting Java 1.6. I also don’t think the test
should be disabled, since the build should be made with a 1.6 JDK
anyway.
Vincent
On 9/24/14, 10:24 AM, Vincent Hennebert wrote:
Hi,
I’ll have some spare time over next week to do a release of XGC. Due to
API changes introduced by the new URI resolution framework I guess we’ll
bump the version number to 2.0. And, while we’re at it, the minimum Java
requirement to 1.6.
If nobody objects by next Monday, I’ll start the release process.
Thanks,
Vincent
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
