On Tue, Sep 30, 2014 at 9:46 AM, Vincent Hennebert <[email protected]> wrote:
> On 30/09/14 17:27, Glenn Adams wrote: > > It sounds like a resolution to the problem will take no more than a > couple > > of minutes, e.g., disable the test, in which case I'd be happy to change > my > > vote to +1. > > I absolutely don’t see what it brings us to disable the test, quite on > the contrary. If a regression happens in that area of the code then the > test will no longer be there to catch it. > It prevents a breakage on 1.7, and it gives more time to put in a better fix. This is commonly known as a "short-term-fix", which is usually a compromise. > > Plus, as I said that won’t change anything to the fact that the code > will behave differently on a 1.7 JVM. Whether that is desirable or not > has to be investigated. > > Finally, it’s still possible to build the artifacts with a 1.7 JDK, just > the test suite doesn’t pass. > > Unless I’m given an excellent reason why we should disable the test, I’m > not going to spend any more time on this. > Are you saying you will abandon doing this release because you don't want to make the 30 second change to disable the test? That seems a bit peevish. > > Vincent > > > > On Tue, Sep 30, 2014 at 9:19 AM, Vincent Hennebert <[email protected] > > > > wrote: > > > >> On 30/09/14 17:04, Glenn Adams wrote: > >>> On Tue, Sep 30, 2014 at 8:54 AM, Vincent Hennebert < > [email protected] > >>> > >>> wrote: > >>> > >>>> On 30/09/14 16:45, Glenn Adams wrote: > >>>>> Were you able to resolve (or disable) the one test (ICC related) that > >>>> fails > >>>>> on 1.7? > >>>> > >>>> See my other email about this: > >>>> http://markmail.org/message/ear2dqifqtgsaukg > >>> > >>> > >>> I guess the answer is NO. In that case, my vote is -1. Please address > >> that > >>> issue before restarting vote. > >> > >> I left 5 days of cooling period before starting the release process [1]. > >> It would have been good to mention this during that period. That would > >> have avoided me to waste time preparing the release. > >> > >> If you maintain your vote, that means I will have to defer the releasing > >> of XGC to someone else. My availability was this week and I don’t know > >> when I will have time again to launch another release process. > >> > >> [1] http://markmail.org/message/mt46g4f2jx5vdmbz > >> > >> Vincent > >> > >> > >>>>> On Tue, Sep 30, 2014 at 8:37 AM, Vincent Hennebert wrote: > >>>>> > >>>>> This is a vote to release XML Graphics Commons 2.0. > >>>>> > >>>>> Artifacts can be found there: > >>>>> http://people.apache.org/~vhennebert/xgc-2.0/ > >>>>> > >>>>> The vote will end on Fri, 3rd Oct at 15:00 UTC. > >>>>> > >>>>> +1 from me. > >>>>> > >>>>> Thanks, > >>>>> Vincent > >>>>>> > >>>>>> > --------------------------------------------------------------------- > >>>>>> To unsubscribe, e-mail: [email protected] > >>>>>> For additional commands, e-mail: > [email protected] > >>>>>> > >>>>>> > >>>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [email protected] > >>>> For additional commands, e-mail: [email protected] > >>>> > >>>> > >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
