On Fri, May 22, 2015 at 3:02 AM, Luis Bernardo <[email protected]> wrote:
> > I release cannot not officially be vetoed ( > http://www.apache.org/foundation/voting.html) but obviously having > consensus is desirable and should be the goal. > > So before I spend time checking and testing the package I would like us to > reach a consensus here whether this vote still stands. > > In my opinion, and given the fact that the number of warning/errors with > checkstyle and findbugs is dependent on the version used, having a litmus > test on checkstyle and findbugs warnings for a release only makes sense if > we were to use the most recent released versions of checkstyle and findbugs. > Since we haven't officially moved to Java 7 as a minimum version, I think we would need to use Findbugs 2. I think there is no problem pinning our release to a specific version of Findbugs or Checkstyle for the purpose of obtaining a warning free build. > > Glenn, can you point us to some examples where no findbugs warnings are a > requirement for a company to use open source software? That would be a good > reason for me to support aborting this vote. Otherwise I am in favor of > proceeding with the vote. In the cases I referred to, it is my professional experience with a number of commercial clients of open source software. I'm afraid it is not documented in a public manner. > > > On 5/21/15 8:16 PM, Glenn Adams wrote: > >> I'm not asking for a policy decision at this time. Rather, I'm asking that >> Simon ensure there are no warnings for the common warning sources we are >> accustomed to using, which for many users, includes: javac, checkstyle, >> findbugs. Some folks also use PMD, but i'm not asking for it here. >> >> On Thu, May 21, 2015 at 12:08 PM, Clay Leeds <[email protected]> >> wrote: >> >> I too would prefer no findbugs* warnings going into a Release, and if >>> it's >>> 'easy' for someone to resolve that issue, then by all means, that's >>> great! >>> >>> However, I'm not prepared to VETO this RELEASE due to this issue. IIRC, >>> this issue has been brought up before, but was never resolved and I don't >>> think now is the time to resolve, unless it's relatively painless. >>> >>> Clay >>> >>> My +1 remains... >>> >>> * [OT] heh... AutoCorrect tried to change that to 'windbags'! ;-) >>> >>> On May 21, 2015, at 11:00 AM, Glenn Adams <[email protected]> wrote: >>>> >>>> I would prefer no findbugs warnings going into the release. I'm finding >>>> more and more commercial uses of code have policies that require no >>>> findbugs warnings. You can simply add entries to the >>>> findbugs-exclude.xml >>>> file to disable the warnings for the release. >>>> >>>> On Thu, May 21, 2015 at 11:42 AM, Simon Steiner < >>>> >>> [email protected]> >>> >>>> wrote: >>>> >>>> Hi, >>>>> >>>>> >>>>> >>>>> Did we agree that these need to be fixed (we never passed a vote to >>>>> fail >>>>> build on findbugs): >>>>> >>>>> >>>>> >>>>> XGC has no findbugs target in ant. >>>>> >>>>> XGC has 6 compiler warnings. >>>>> >>>>> >>>>> >>>>> FOP has 124 findbugs warnings: >>>>> >>>>> >>>>> >>>>> >>> https://builds.apache.org/view/XMLGraphics/job/xmlgraphics-fop/ws/build/report_findbugs.html >>> >>>> >>>>> >>>>> Thanks >>>>> >>>>> >>>>> >>>>> *From:* Glenn Adams [mailto:[email protected]] >>>>> *Sent:* 21 May 2015 18:06 >>>>> *To:* FOP Developers; XML Graphics Project >>>>> *Subject:* Re: [VOTE] Release XML Graphics FOP 2.0 >>>>> >>>>> >>>>> >>>>> Before you create the final artifact, please ensure there are no >>>>> >>>> compiler, >>> >>>> checkstyle, or findbugs warnings. Same applies for XGC 2.0.1. >>>>> >>>>> >>>>> >>>>> On Thu, May 21, 2015 at 7:39 AM, Glenn Adams <[email protected]> wrote: >>>>> >>>>> +1 >>>>> >>>>> >>>>> >>>>> On Thu, May 21, 2015 at 7:21 AM, Simon Steiner < >>>>> >>>> [email protected]> >>> >>>> wrote: >>>>> >>>>> -----BEGIN PGP SIGNED MESSAGE----- >>>>> Hash: SHA1 >>>>> >>>>> Hi, >>>>> >>>>> This is a vote to release XML Graphics FOP 2.0. >>>>> >>>>> Artifacts can be found there: >>>>> https://people.apache.org/~ssteiner/fop-2.0 >>>>> >>>>> The release is signed with the key: >>>>> https://people.apache.org/~ssteiner/KEYS >>>>> >>>>> The vote will end on 28/5/2015 >>>>> >>>>> +1 from me. >>>>> >>>>> Thanks >>>>> -----BEGIN PGP SIGNATURE----- >>>>> Version: GnuPG v1 >>>>> >>>>> iQIcBAEBAgAGBQJVXduFAAoJEFuT8d98223qUtYP/3NaJGfuElP3RyKQFW71J7Fz >>>>> M/RXeiHQrsxrEg0MW9HXnzGLDnqlmUiFHIs3EHU1vVBy2kBVD0OO42Eh68FqcwWS >>>>> maqzGQHGKtyKhxS52X3mb/nSv8N/php1PlvqJbbNYl4KqMhT9GhOhilhtIXKD+Z5 >>>>> KMIkDFkFPcN++H65CSMn3ynmR3XzUZffzrGwpjIBIj7gP2zW6ZJ5qM/E05k/90rd >>>>> QsRT/UYBN3bGolZp3oOHLnB/H6KwGsHOfVmrxaFwhLGJnqpaBgYe2+dQ6I50Twx9 >>>>> tlJhtv0/7nAq/Py/vPQj2kTDC7XV0pQhTFbhnhlJ4smk21G9XRV12nKlQtRmiLqp >>>>> Yrmn8HPqSia6UZ2zl5ObDMVLjc+vnsUzkqa8ONkSmUW23XziF3anojaf4Hb8ENNg >>>>> 8k8KpVQU1z1uOrPYxQDK9ajJPmlUocOpfVTBWyzyL39bhmJmx479TSViYGy2j29v >>>>> 9JXN3r36tKfxxepT2u0npLPdqPi1MrOhUdMdFNuxZdIG9W2KgYDNqvaK4dTmYBT+ >>>>> kghoQzM8Ega8bKPe+mMmoYsAEPo9iftnellcLKk7dBp6SRBVOdPLa8K+OKF1UAqW >>>>> OrOS4ahlkRk3k0cl/SdSBfnEQcclVD6WenNZA2T09RELx8riWnVuRjmu+GSLhgzx >>>>> Vs3s8aMGH8xBEN0SEv+l >>>>> =t6hJ >>>>> -----END PGP SIGNATURE----- >>>>> >>>> >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
