ok, that's a good point; we'll leave it at xmlgraphics-commons then; we can reconsider whether we want to add a 'xmlgraphics-' prefix to batik and fop when we are ready to transition to maven on the latter
On Tue, Feb 23, 2016 at 11:27 AM, Simon Steiner <[email protected]> wrote: > Hi, > > > http://central.maven.org/maven2/org/apache/xmlgraphics/xmlgraphics-commons/2.1/xmlgraphics-commons-2.1.pom > currently its "<artifactId>xmlgraphics-commons</artifactId>" > > someone upgrading shouldn’t have to change artifact id in their config. > > Thanks > > -----Original Message----- > From: Glenn Adams [mailto:[email protected]] > Sent: 23 February 2016 17:56 > To: XML Graphics Project <[email protected]> > Subject: Re: [VOTE] Merge from xmlgraphics/commons/branches/maven to trunk. > > Given the various input, I've decided to go with the following artifact > ids: > > - commons-xmlgraphics > - batik > - fop > > I would have liked to use 'commons' alone, given the group id would > sufficiently distinguish; however, there is clearly a convention of using > commons-<...> in Maven Central, both in commons.apache.org, other apache > projects, and non-apache projects. So, to avoid conflicts on doing search > on Maven Central, the longer artifact spelling seems appropriate. > > On Tue, Feb 23, 2016 at 6:47 AM, Clay Leeds <[email protected]> > wrote: > > > I guess I could also go for this: > > > > - xmlgraphics-commons > > - batik > > - fop > > > > However, I like consistency more so I prefer the other way. > > > > Like Glenn, I think that 'commons-xmlgraphics' makes it more like it's > > from of the commons.apache.org team. > > > > That said, I don't have a lot of energy here, so I'm happy with what > > the team decides here. > > > > Clay > > > > > On Feb 23, 2016, at 5:29 AM, Clay Leeds <[email protected]> > > wrote: > > > > > > Hi folks, > > > > > > I'm thinking it'd be best to have consistency and use the prefix > > 'xmlgraphics-' for all project JAR files: > > > > > > - xmlgraphics-commons > > > - xmlgraphics-batik > > > - xmlgraphics-fop > > > > > > I don't have a lot of energy behind this, but I do like consistency. > > > > > > IOW, I'm +0 for the naming convention and +1 for the merge. ;-) > > > > > > Clay > > > > > >> On Feb 23, 2016, at 3:02 AM, Matthias Reischenbacher < > > [email protected]> wrote: > > >> > > >> Hi Glenn, > > >> > > >> I just checked some other Apache projects that use maven. Here is a > > >> short list of their artifactIds: > > >> > > >> Jackrabbit: > > >> * jackrabbit-api > > >> * jackrabbit-jcr-commons > > >> * jackrabbit-core > > >> etc. > > >> > > >> Apache Commons: > > >> * commons-codec > > >> * commons-fileupload > > >> etc. > > >> > > >> PDFBox: > > >> * pdfbox > > >> * fontbox > > >> * jempbox > > >> etc. > > >> > > >> If we use commons-xmlgraphics/xgc we would introduce a third naming > > >> scheme and it would still be associated more with Apache Commons > > >> than Apache XMLGraphics. I think we should either stick to your > > >> original proposal and use "commons", "fop" and "batik". Or should > change to: > > >> "xmlgraphics-commons", "xmlgraphics-batik", "xmlgraphics-fop" (or > > >> with "xgc-" prefix). > > >> > > >> BR, > > >> Matthias > > >> > > >>> On 22.02.2016 18:37, Glenn Adams wrote: > > >>> On Mon, Feb 22, 2016 at 2:07 PM, Matthias Reischenbacher < > > >>> [email protected]> wrote: > > >>> > > >>>> Hi Glenn, > > >>>> > > >>>> if we use the "commons-2.2.0.SNAPSHOT.jar" naming scheme, the jar > > >>>> file will be wrongly associated with jar files of > > http://commons.apache.org/ > > >>>> (some examples: commons-cli-1.0.jar, commons-codec-1.5 etc.). > > >>>> > > >>>> I think it would be better to normalize the batik and fop naming > > scheme. > > >>> How about we use one of the following as the artifact id: > > >>> > > >>> - commons-xmlgraphics > > >>> - commons-xgc > > >>> - commons-graphics > > >>> > > >>> and leave batik and fop as is? > > >>> > > >>> I have a slight preference for 'commons-xgc' but I'm also OK with > > >>> 'commons-xmlgraphics'. > > >>> > > >>> > > >>>> BR, > > >>>> Matthias > > >>>> > > >>>>> On 22.02.2016 18:01, Glenn Adams wrote: > > >>>>> On Mon, Feb 22, 2016 at 6:23 AM, Simon Steiner < > > >>>> [email protected]> > > >>>>> wrote: > > >>>>> > > >>>>>> Hi, > > >>>>>> > > >>>>>> Ant naming is: xmlgraphics-commons-svn-trunk.jar Mvn naming is: > > >>>>>> commons-2.2.0-SNAPSHOT.jar > > >>>>> Correct. We will be using the maven naming scheme now for maven > > >>>>> built artifacts, which is: > > >>>>> > > >>>>> groupId:artifactId:version > > >>>>> > > >>>>> We will use org.apache.xmlgraphics as the groupId and the > > >>>>> following > > >>>>> artifactIds: > > >>>>> > > >>>>> - commons > > >>>>> - batik > > >>>>> - fop > > >>>>> > > >>>>> Note that of our 3 current projects built by ant, only > > >>>> xmlgraphics-commons > > >>>>> has a prefix, while batik and fop do not. If they had all used > > >>>>> an 'xmlgraphics-' prefix, then we would probably want to include > > >>>>> that > > prefix > > >>>>> in our maven artifact identifiers. However, since 2 don't use a > > prefix > > >>>> and > > >>>>> 1 does, we are inconsistent in our present names, and should > > normalize > > >>>> this > > >>>>> by removing the prefix on commons. > > >>>>> > > >>>>> Do you anticipate a problem arising from this change? I expect > > >>>>> that external users that want to use the new maven artifacts can > > >>>>> make the appropriate name changes on their side. If they are > > >>>>> using maven dependencies, they will use the maven artifact > > >>>>> naming conventions to > > pull > > >>>>> in xmlgraphics artifacts. > > >>>>> > > >>>>> > > >>>>>> Thanks > > >>>>>> > > >>>>>> -----Original Message----- > > >>>>>> From: Matthias Reischenbacher [mailto:[email protected]] > > >>>>>> Sent: 22 February 2016 12:36 > > >>>>>> To: [email protected] > > >>>>>> Subject: Re: [VOTE] Merge from > > >>>>>> xmlgraphics/commons/branches/maven to > > >>>> trunk. > > >>>>>> I tested successfully with Java 7 on Windows 10. With Java 8 > > >>>>>> the > > >>>> findbugs > > >>>>>> target doesn't work, but this is the same for ant and maven. > > >>>>>> > > >>>>>> +1 > > >>>>>> > > >>>>>> Btw... I also tried to import the maven project in eclipse 4.4. > > >>>>>> The > > main > > >>>>>> source and test folders are recognized correctly, but > > >>>>>> additionally a > > >>>> source > > >>>>>> folder for "src/java" is added, which doesn't exist, so eclipse > > reports > > >>>> the > > >>>>>> error "Project 'commons' is missing required source folder: > > >>>>>> 'src/java'´" > > >>>>>> > > >>>>>>> On 21.02.2016 04:00, Glenn Adams wrote: > > >>>>>>> I would like to start a vote on merging from > > >>>>>>> xmlgraphics/commons/branches/maven to trunk. Please respond by > > >>>>>>> Wednesday, 02/24, 1700Z. Lack of a response will be > > >>>>>>> interpreted as > > +0. > > >>>>>>> > > >>>>>>> In addition to adding a Maven POM, this merge will begin the > > process > > >>>>>>> of migrating to the typical maven directory hierarchy, i.e., > > >>>>>>> > > >>>>>>> src/main/java > > >>>>>>> src/main/resources > > >>>>>>> src/test/java > > >>>>>>> src/test/resources > > >>>>>>> > > >>>>>>> etc. > > >>>>>>> > > >>>>>>> I have retained symbolic links to permit ant builds to > > >>>>>>> continue to > > >>>>>> function. > > >>>>>>> The following run without error (on my platform): > > >>>>>>> > > >>>>>>> mvn clean test > > >>>>>>> ant clean junit > > >>>>>>> > > >>>>>>> I am using the following tool versions: > > >>>>>>> > > >>>>>>> $ mvn -v > > >>>>>>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > > >>>>>>> 2015-11-10T09:41:47-07:00) > > >>>>>>> Maven home: /opt/local/share/java/maven3 Java version: > > >>>>>>> 1.7.0_80, > > >>>>>>> vendor: Oracle Corporation Java home: > > >>>>>>> /Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Hom > > >>>>>>> e/jre Default locale: en_US, platform encoding: UTF-8 OS name: > > >>>>>>> "mac os > > x", > > >>>>>>> version: "10.11.3", arch: "x86_64", family: "mac" > > >>>>>>> > > >>>>>>> $ ant -version > > >>>>>>> Apache Ant(TM) version 1.9.6 compiled on June 29 2015 Please > > >>>>>>> let me know if you encounter problems on JDK 6. > > >>>>>> > > >>>>>> > > --------------------------------------------------------------------- > > >>>>>> To unsubscribe, e-mail: > > >>>>>> [email protected] > > >>>>>> For additional commands, e-mail: > > [email protected] > > >>>>>> > > >>>>>> > > >>>>>> > > >>>>>> > > --------------------------------------------------------------------- > > >>>>>> To unsubscribe, e-mail: > > >>>>>> [email protected] > > >>>>>> For additional commands, e-mail: > > [email protected] > > >>>> > > >>>> ----------------------------------------------------------------- > > >>>> ---- To unsubscribe, e-mail: > > >>>> [email protected] > > >>>> For additional commands, e-mail: > > >>>> [email protected] > > >> > > >> > > >> > > >> ------------------------------------------------------------------- > > >> -- To unsubscribe, e-mail: > > >> [email protected] > > >> For additional commands, e-mail: > > >> [email protected] > > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
