[ 
https://issues.apache.org/jira/browse/XGC-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021490#comment-16021490
 ] 

mt commented on XGC-98:
-----------------------

(hit enter too soon, sorry)

https://github.com/apache/xml-graphics-commons/commit/35311e33d160513eb7f70ce4e9d505d0c0b836d5

So according to the history, the fix was made on the file AFTER it was already 
moved somewhere else, and looking at the current version in the trunk, the fix 
is indeed not included:

https://github.com/apache/xml-graphics-commons/blob/trunk/src/main/java/org/apache/xmlgraphics/image/loader/impl/AbstractImageSessionContext.java#L121

Am I missing something here or did something go seriously wrong there and the 
fix is indeed not in the trunk?

> UndeclaredThrowableException while loading images
> -------------------------------------------------
>
>                 Key: XGC-98
>                 URL: https://issues.apache.org/jira/browse/XGC-98
>             Project: XMLGraphicsCommons
>          Issue Type: Bug
>    Affects Versions: 1.5, 2.0.1
>            Reporter: Vlad Arkhipov
>            Assignee: simon steiner
>         Attachments: InvocationTargetException.patch
>
>
> UndeclaredThrowableException is thrown if an image cannot be loaded for some 
> reason.
> {code}
> Caused by: java.lang.reflect.UndeclaredThrowableException
>         at com.sun.proxy.$Proxy313.readUnsignedInt(Unknown Source)
>         at 
> org.apache.xmlgraphics.image.loader.impl.PreloaderEPS.preloadImage(PreloaderEPS.java:65)
>  [xmlgraphics-commons-1.5.jar:1.5]
>         at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:175)
>  [xmlgraphics-commons-1.5.jar:1.5]
>         at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  [xmlgraphics-commons-1.5.jar:1.5]
>         at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:122)
>  [xmlgraphics-commons-1.5.jar:1.5]
>         at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-1.1.jar:]
>         at org.apache.fop.fo.FObj.processNode(FObj.java:124) [fop-1.1.jar:]
>         at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:280)
>  [fop-1.1.jar:]
>         at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:175) 
> [fop-1.1.jar:]
> ...
> Caused by: java.lang.reflect.InvocationTargetException
>         at sun.reflect.GeneratedMethodAccessor2609.invoke(Unknown Source) 
> [:1.8.0_25]
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [rt.jar:1.8.0_25]
>         at java.lang.reflect.Method.invoke(Method.java:483) [rt.jar:1.8.0_25]
>         at 
> org.apache.xmlgraphics.image.loader.impl.AbstractImageSessionContext$ObservingImageInputStreamInvocationHandler.invoke(AbstractImageSessionContext.java:219)
>  [
> xmlgraphics-commons-1.5.jar:1.5]
>         ... 254 more
> Caused by: java.io.EOFException
>         at 
> javax.imageio.stream.ImageInputStreamImpl.readInt(ImageInputStreamImpl.java:251)
>  [rt.jar:1.8.0_25]
>         at 
> javax.imageio.stream.ImageInputStreamImpl.readUnsignedInt(ImageInputStreamImpl.java:266)
>  [rt.jar:1.8.0_25]
>         ... 258 more
> {code}
> The problem being that InvocationHandlers in the classes 
> AbstractImageSessionContext and ObservableStream do not handle 
> InvocationTargetException properly, and the exception is propagated up to the 
> proxied interface where InvocationTargetException is not specified.
> I am not sure if you accept pull requests on Github, anyway here it is 
> https://github.com/apache/xml-graphics-commons/pull/1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: general-h...@xmlgraphics.apache.org

Reply via email to