vapier      14/03/20 19:30:33

  Modified:             ssl-cert.eclass
  Log:
  misc style fixes -- do not hardcode full path to `openssl`

Revision  Changes    Path
1.21                 eclass/ssl-cert.eclass

file : 
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ssl-cert.eclass?rev=1.21&view=markup
plain: 
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ssl-cert.eclass?rev=1.21&content-type=text/plain
diff : 
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ssl-cert.eclass?r1=1.20&r2=1.21

Index: ssl-cert.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/ssl-cert.eclass,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- ssl-cert.eclass     3 Jan 2013 19:19:55 -0000       1.20
+++ ssl-cert.eclass     20 Mar 2014 19:30:32 -0000      1.21
@@ -1,6 +1,6 @@
-# Copyright 1999-2011 Gentoo Foundation
+# Copyright 1999-2014 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/ssl-cert.eclass,v 1.20 2013/01/03 
19:19:55 alonbl Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/ssl-cert.eclass,v 1.21 2014/03/20 
19:30:32 vapier Exp $
 
 # @ECLASS: ssl-cert.eclass
 # @MAINTAINER:
@@ -16,16 +16,14 @@
 # @ECLASS-VARIABLE: SSL_CERT_MANDATORY
 # @DESCRIPTION:
 # Set to non zero if ssl-cert is mandatory for ebuild.
-#
-SSL_CERT_MANDATORY="${SSL_CERT_MANDATORY:-0}"
+: ${SSL_CERT_MANDATORY:=0}
 
 # @ECLASS-VARIABLE: SSL_CERT_USE
 # @DESCRIPTION:
 # Use flag to append dependency to.
-#
-SSL_CERT_USE="${SSL_CERT_USE:-ssl}"
+: ${SSL_CERT_USE:=ssl}
 
-if [[ "${SSL_CERT_MANDATORY}" = 0 ]]; then
+if [[ "${SSL_CERT_MANDATORY}" == "0" ]]; then
        DEPEND="${SSL_CERT_USE}? ( dev-libs/openssl )"
        IUSE="${SSL_CERT_USE}"
 else
@@ -108,7 +106,7 @@
 gen_key() {
        local base=`get_base $1`
        ebegin "Generating ${SSL_BITS} bit RSA key${1:+ for CA}"
-       /usr/bin/openssl genrsa -rand "${SSL_RANDOM}" \
+       openssl genrsa -rand "${SSL_RANDOM}" \
                -out "${base}.key" "${SSL_BITS}" &> /dev/null
        eend $?
 
@@ -125,7 +123,7 @@
 gen_csr() {
        local base=`get_base $1`
        ebegin "Generating Certificate Signing Request${1:+ for CA}"
-       /usr/bin/openssl req -config "${SSL_CONF}" -new \
+       openssl req -config "${SSL_CONF}" -new \
                -key "${base}.key" -out "${base}.csr" &>/dev/null
        eend $?
 
@@ -145,13 +143,13 @@
        local base=`get_base $1`
        if [ "${1}" ] ; then
                ebegin "Generating self-signed X.509 Certificate for CA"
-               /usr/bin/openssl x509 -extfile "${SSL_CONF}" \
+               openssl x509 -extfile "${SSL_CONF}" \
                        -days ${SSL_DAYS} -req -signkey "${base}.key" \
                        -in "${base}.csr" -out "${base}.crt" &>/dev/null
        else
                local ca=`get_base 1`
                ebegin "Generating authority-signed X.509 Certificate"
-               /usr/bin/openssl x509 -extfile "${SSL_CONF}" \
+               openssl x509 -extfile "${SSL_CONF}" \
                        -days ${SSL_DAYS} -req -CAserial "${SSL_SERIAL}" \
                        -CAkey "${ca}.key" -CA "${ca}.crt" \
                        -in "${base}.csr" -out "${base}.crt" &>/dev/null
@@ -246,7 +244,7 @@
                install -m0444 "${base}.csr" "${ROOT}${cert}.csr"
                install -m0444 "${base}.crt" "${ROOT}${cert}.crt"
                install -m0400 "${base}.pem" "${ROOT}${cert}.pem"
-               count=$((${count}+1))
+               : $(( ++count ))
        done
 
        # Resulting status




Reply via email to