commit:     9f1ab1c993348c521d8371eb609c6f7145c335bf
Author:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
AuthorDate: Fri Apr  4 03:15:47 2025 +0000
Commit:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
CommitDate: Fri Apr  4 03:44:28 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f1ab1c9

sci-electronics/spice: "fix" Modern C issues by declaring defeat

The software is extremely crusty. As mentioned in the previous commit,
it hasn't been maintained since 1993 and there are derivative projects
which likely solve these issues. The code has "worked" since 1993 and I
suspect unlikely to ever be of much interest to new platforms, given
that it's only even useful as a point of reference compared to its
modern derivatives. Keep in mind the code is so old that it's from back
when the most recent brand new C revision supported implicit function
declarations.

Trying to solve its C issues seems unworthwhile. Just -std=c89 it.
Actually, gnu89 since it depends on `#define linux` to detect the
platform. :P

Closes: https://bugs.gentoo.org/919301
Closes: https://bugs.gentoo.org/944870
Closes: https://bugs.gentoo.org/945068
Signed-off-by: Eli Schwartz <eschwartz <AT> gentoo.org>

 sci-electronics/spice/spice-3.5.5-r4.ebuild | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sci-electronics/spice/spice-3.5.5-r4.ebuild 
b/sci-electronics/spice/spice-3.5.5-r4.ebuild
index 1fd93a015f94..86ec6e1741ec 100644
--- a/sci-electronics/spice/spice-3.5.5-r4.ebuild
+++ b/sci-electronics/spice/spice-3.5.5-r4.ebuild
@@ -41,6 +41,10 @@ src_prepare() {
        # spice accepts -O1 at most
        replace-flags -O* -O1
 
+       # The code is from 1989, later updated in 1993. It is deeply 
incompatible
+       # with Modern C (c99). It also needs `#define linux` from gnu...
+       append-flags -std=gnu89
+
        # Avoid re-creating WORKDIR due to stupid mtime
        touch ..
 

Reply via email to