commit: b463171a6debe93cde73f5e966dbf7d8686f2399 Author: Alfredo Tupone <tupone <AT> gentoo <DOT> org> AuthorDate: Wed Jun 18 19:33:25 2025 +0000 Commit: Alfredo Tupone <tupone <AT> gentoo <DOT> org> CommitDate: Wed Jun 18 19:41:19 2025 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b463171a
dev-util/breakpad: nullptr does not need reinterpret_cast Closes: https://bugs.gentoo.org/943992 Signed-off-by: Alfredo Tupone <tupone <AT> gentoo.org> dev-util/breakpad/breakpad-2023.06.01.ebuild | 3 ++- dev-util/breakpad/breakpad-2024.02.16.ebuild | 1 + .../files/breakpad-2023.06.01-reinterpret.patch | 28 ++++++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/dev-util/breakpad/breakpad-2023.06.01.ebuild b/dev-util/breakpad/breakpad-2023.06.01.ebuild index a9c53669718b..7ebd27057a6e 100644 --- a/dev-util/breakpad/breakpad-2023.06.01.ebuild +++ b/dev-util/breakpad/breakpad-2023.06.01.ebuild @@ -1,4 +1,4 @@ -# Copyright 2022-2024 Gentoo Authors +# Copyright 2022-2025 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 EAPI=8 @@ -28,6 +28,7 @@ REQUIRED_USE="elibc_musl? ( !tools )" PATCHES=( "${FILESDIR}"/${P}-gentoo.patch + "${FILESDIR}"/${P}-reinterpret.patch ) src_prepare() { diff --git a/dev-util/breakpad/breakpad-2024.02.16.ebuild b/dev-util/breakpad/breakpad-2024.02.16.ebuild index fce1716bd016..8d03965e367e 100644 --- a/dev-util/breakpad/breakpad-2024.02.16.ebuild +++ b/dev-util/breakpad/breakpad-2024.02.16.ebuild @@ -28,6 +28,7 @@ REQUIRED_USE="elibc_musl? ( !tools )" PATCHES=( "${FILESDIR}"/${PN}-2023.06.01-gentoo.patch + "${FILESDIR}"/${PN}-2023.06.01-reinterpret.patch ) src_prepare() { diff --git a/dev-util/breakpad/files/breakpad-2023.06.01-reinterpret.patch b/dev-util/breakpad/files/breakpad-2023.06.01-reinterpret.patch new file mode 100644 index 000000000000..20b89289b606 --- /dev/null +++ b/dev-util/breakpad/files/breakpad-2023.06.01-reinterpret.patch @@ -0,0 +1,28 @@ +--- a/src/processor/minidump_unittest.cc 2025-06-18 21:26:27.349826380 +0200 ++++ b/src/processor/minidump_unittest.cc 2025-06-18 21:27:11.487348678 +0200 +@@ -389,10 +389,10 @@ + ASSERT_EQ(0xa898f11bU, thread_id); + + MinidumpContext* md_context = md_thread->GetContext(); +- ASSERT_NE(reinterpret_cast<MinidumpContext*>(NULL), md_context); ++ ASSERT_NE(nullptr, md_context); + + MinidumpMemoryRegion* md_stack = md_thread->GetMemory(); +- ASSERT_EQ(reinterpret_cast<MinidumpMemoryRegion*>(NULL), md_stack); ++ ASSERT_EQ(nullptr, md_stack); + } + + TEST(Dump, ThreadMissingContext) { +@@ -431,10 +431,10 @@ + ASSERT_TRUE(md_thread->GetThreadID(&thread_id)); + ASSERT_EQ(0xa898f11bU, thread_id); + MinidumpMemoryRegion* md_stack = md_thread->GetMemory(); +- ASSERT_NE(reinterpret_cast<MinidumpMemoryRegion*>(NULL), md_stack); ++ ASSERT_NE(nullptr, md_stack); + + MinidumpContext* md_context = md_thread->GetContext(); +- ASSERT_EQ(reinterpret_cast<MinidumpContext*>(NULL), md_context); ++ ASSERT_EQ(nullptr, md_context); + } + + TEST(Dump, OneUnloadedModule) {
