commit:     a9f83f17feb24cb1ba9ab364aee16be7ef4dd834
Author:     Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Thu Jul 24 21:18:33 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Aug  2 16:31:28 2025 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=a9f83f17

isolated-functions.sh: suppress the SC2219 notice throughout

As a matter of style, shellcheck recommends that the (( … )) compound
command be preferred over the let builtin for arithmetic. Presently,
this recommendation is being suppressed for the body of the assert()
function. Instead, suppress it for the "isolated-functions.sh" unit in
its entirety. The reason for this change is that a forthcoming commit
will introduce an additional function that uses the let builtin.

See-also: 91283cf5b59a482061bf4cf440e774a0826c664b
Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 bin/isolated-functions.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
index b2f4b93628..546efa0190 100644
--- a/bin/isolated-functions.sh
+++ b/bin/isolated-functions.sh
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 # Copyright 1999-2024 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
-# shellcheck disable=2128,2185
+# shellcheck disable=2128,2185,2219
 
 source "${PORTAGE_BIN_PATH:?}/eapi.sh" || exit
 
@@ -23,7 +23,6 @@ fi
 shopt -s expand_aliases
 
 assert() {
-       # shellcheck disable=2219
        IFS='|' expression=${PIPESTATUS[*]} let '! expression' || die "$@"
 }
 

Reply via email to