commit:     ebd2bf2b6d8ecd1e68f16e9f2672f09c2647c997
Author:     Florian Schmaus <flow <AT> gentoo <DOT> org>
AuthorDate: Sat Sep 13 18:36:08 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Sep 14 00:15:05 2025 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=ebd2bf2b

bintree: Add missing 'break' in UseCachedCopyOfRemoteIndex

When we added support to fetch Packages.gz first, a new lopo was added
to the _populate_remote() logic, iterating over ("Packages.gz",
"Packages"). There are two situtations where we want to break out of
the loop: when the remote package index was fetched or when the cached
version of the package index was used. However,
fd55382a4935 ("bintree: Accelerate index fetch by requesting
Packages.gz first"), only added a break statement for the first
case (successful fetch). This adds the missing break statement for the
second case (use cached version).

Fixes: fd55382a4935 ("bintree: Accelerate index fetch by requesting Packages.gz 
first")
Signed-off-by: Florian Schmaus <flow <AT> gentoo.org>
Part-of: https://github.com/gentoo/portage/pull/1465
Signed-off-by: Sam James <sam <AT> gentoo.org>

 lib/portage/dbapi/bintree.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/portage/dbapi/bintree.py b/lib/portage/dbapi/bintree.py
index 46f5e7f8b9..9d695059d6 100644
--- a/lib/portage/dbapi/bintree.py
+++ b/lib/portage/dbapi/bintree.py
@@ -1670,6 +1670,7 @@ class binarytree:
                             )
                             + "\n"
                         )
+                    break
                 except OSError as e:
                     if (
                         remote_pkgindex_file == "Packages.gz"

Reply via email to