commit: ed3a22f2748aea9f7139aaef5a7b009973618310
Author: Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Tue Oct 14 07:08:42 2025 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Oct 14 12:59:09 2025 +0000
URL:
https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=ed3a22f2
Reorganise and trim the _update_columns() commentary
Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Signed-off-by: Sam James <sam <AT> gentoo.org>
functions.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/functions.sh b/functions.sh
index 0c98e84..ba895df 100644
--- a/functions.sh
+++ b/functions.sh
@@ -871,14 +871,13 @@ _update_columns()
# updates can be performed is throttled to intervals of half a
# second. Secondly, if running on bash then the COLUMNS variable
# may be gauged, albeit only in situations where doing so can be
- # expected to work reliably; it is an unreliable method where
- # operating from a subshell. Note that executing true(1) is
- # faster than executing stty(1) within a comsub.
+ # expected to work reliably.
# shellcheck disable=3028
if _should_throttle 50; then
test "${genfun_cols}"
return
elif [ "${genfun_bin_true}" ] && [ "$$" = "${BASHPID}" ]; then
+ # To execute the true binary is faster than stty(1).
"${genfun_bin_true}"
set -- 0 "${COLUMNS}"
else
