commit: 709284531e0383fcc428b7112916d585621c0a76
Author: Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
AuthorDate: Tue Jan 27 01:09:52 2026 +0000
Commit: Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
CommitDate: Thu Mar 12 15:21:02 2026 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=70928453
myspell-r2.eclass: remove totally incorrect use of assert
It should have always been die.
>From gentoo-historical-2.git,
```
commit 39b01d59be512eb9ed10a66db19513e6b53130f4
Author: Tomas Chvatal <scarabeus <AT> gentoo.org>
AuthorDate: Tue Apr 24 08:49:09 2012
Commit: Tomas Chvatal <scarabeus <AT> gentoo.org>
CommitDate: Tue Apr 24 08:49:09 2012
Add myspell-r2.eclass which is just eclassdoced myspell.eclass with removed
no-longer required stuff.
```
I have many questions. However, the one which is relevant here is: why
did this new eclass *add* a new src_unpack, which called a single simple
command, `unzip`, and then uses assert to catch pipe errors in it.
assert is banned in EAPI 9, so it has to go anyway. Take this
opportunity to perform a 14 year old cleanliness fix.
Signed-off-by: Eli Schwartz <eschwartz <AT> gentoo.org>
eclass/myspell-r2.eclass | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/eclass/myspell-r2.eclass b/eclass/myspell-r2.eclass
index 05d48dc97dee..a8655314fd0b 100644
--- a/eclass/myspell-r2.eclass
+++ b/eclass/myspell-r2.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2023 Gentoo Authors
+# Copyright 1999-2026 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
# @ECLASS: myspell-r2.eclass
@@ -61,8 +61,7 @@ myspell-r2_src_unpack() {
case ${f} in
*.oxt)
echo ">>> Unpacking "${DISTDIR}/${f}" to ${PWD}"
- unzip -qoj "${DISTDIR}"/${f}
- assert "failed unpacking ${DISTDIR}/${f}"
+ unzip -qoj "${DISTDIR}"/${f} || die "failed
unpacking ${DISTDIR}/${f}"
;;
*) unpack ${f} ;;
esac
