commit:     a4fcc78c90893103d012ae1dc05a2a8f42d7cdaa
Author:     Alon Bar-Lev <alonbl <AT> gentoo <DOT> org>
AuthorDate: Sat Nov  7 20:02:59 2015 +0000
Commit:     Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
CommitDate: Sun Nov  8 07:13:36 2015 +0000
URL:        https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=a4fcc78c

net: bridge: add warning when using sysfs variables without prefix

Signed-off-by: Alon Bar-Lev <alonbl <AT> gentoo.org>

 net/bridge.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/bridge.sh b/net/bridge.sh
index 407b578..3dfd8b1 100644
--- a/net/bridge.sh
+++ b/net/bridge.sh
@@ -129,6 +129,7 @@ bridge_pre_start()
                for prefix in "" bridge_; do
                        eval s=\$${prefix}${n}_${IFVAR}
                        if [ -n "${s}" ]; then
+                               [ -z "${prefix}" ] && ewarn "sysfs key 
'${n}_${IFVAR}' should be prefixed, please add bridge_ prefix."
                                einfo "Setting ${n}: ${s}"
                                echo "${s}" >"${x}" || \
                                eerror "Failed to configure $n (${n}_${IFVAR})"
@@ -167,6 +168,7 @@ bridge_pre_start()
                                for prefix in "" brport_; do
                                        eval s=\$${prefix}${n}_${IFVAR}
                                        if [ -n "${s}" ]; then
+                                               [ -z "${prefix}" ] && ewarn 
"sysfs key '${n}_${IFVAR}' should be prefixed, please add brport_ prefix."
                                                einfo "Setting ${n}@${IFACE}: 
${s}"
                                                echo "${s}" >"${x}" || \
                                                eerror "Failed to configure $n 
(${n}_${IFVAR})"

Reply via email to