commit:     f969ccffe04df2d1eeb014dfe67d58177da476fb
Author:     Gilles Dartiguelongue <eva <AT> gentoo <DOT> org>
AuthorDate: Sun Jan 22 12:34:13 2017 +0000
Commit:     Gilles Dartiguelongue <eva <AT> gentoo <DOT> org>
CommitDate: Sun Jan 22 12:34:13 2017 +0000
URL:        https://gitweb.gentoo.org/proj/grumpy.git/commit/?id=f969ccff

sync: reduce unneeded conditional evaluation

tags cannot be evaluated to go though these branches after the first if so 
switch to elif.

 backend/lib/sync.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backend/lib/sync.py b/backend/lib/sync.py
index 429d14b..4cbfe1b 100644
--- a/backend/lib/sync.py
+++ b/backend/lib/sync.py
@@ -36,7 +36,7 @@ def get_project_data():
             tag = elem.tag.lower()
             if tag in ['email']:
                 proj[tag] = elem.text.lower()
-            if tag in ['name', 'url', 'description']:
+            elif tag in ['name', 'url', 'description']:
                 proj[tag] = elem.text
             elif tag == 'member':
                 member = {}
@@ -46,7 +46,7 @@ def get_project_data():
                     member_tag = member_elem.tag.lower()
                     if member_tag in ['email']:
                         member[member_tag] = member_elem.text.lower()
-                    if member_tag in ['name', 'role']:
+                    elif member_tag in ['name', 'role']:
                         member[member_tag] = member_elem.text
                 if 'email' in member:
                     proj['members'].append(member)

Reply via email to