commit:     8e1bff5146ca3f6305ce7349b963c8fa19bc9b63
Author:     Michał Górny <mgorny <AT> gentoo <DOT> org>
AuthorDate: Thu Feb 23 18:20:01 2017 +0000
Commit:     Michał Górny <mgorny <AT> gentoo <DOT> org>
CommitDate: Wed Mar  8 07:35:33 2017 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e1bff51

ruby-fakegem.eclass: Remove completely unnecessary 'eval ls'

Filename expansion is performed when the variable is referenced unquoted
already. There is really no need to call 'ls' on top of that, and even
less reason to wrap it all in 'eval'.

 eclass/ruby-fakegem.eclass | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass
index 69ab29f7fb8..b1795fa46c9 100644
--- a/eclass/ruby-fakegem.eclass
+++ b/eclass/ruby-fakegem.eclass
@@ -521,9 +521,8 @@ all_fakegem_install() {
 
                if [[ -d "${bindir}" ]]; then
                        pushd "${bindir}" &>/dev/null || die
-                       local binaries=$(eval ls ${RUBY_FAKEGEM_BINWRAP})
-                       for binary in $binaries; do
-                               ruby_fakegem_binwrapper $binary
+                       for binary in ${RUBY_FAKEGEM_BINWRAP}; do
+                               ruby_fakegem_binwrapper "${binary}"
                        done
                        popd &>/dev/null || die
                fi

Reply via email to