commit:     858a4bf9eb22523b936651861d74780843d68f19
Author:     Michał Górny <mgorny <AT> gentoo <DOT> org>
AuthorDate: Mon Apr 22 07:22:44 2019 +0000
Commit:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
CommitDate: Mon May 13 18:50:22 2019 +0000
URL:        https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=858a4bf9

quickstart: Remove unnecessary src_install() from most examples

Remove most of src_install() redefinitions since they completely match
the default.  Leave the initial one for demonstration purposes,
and the last one since it is more complex.

Signed-off-by: Michał Górny <mgorny <AT> gentoo.org>
Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org>

 quickstart/text.xml | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/quickstart/text.xml b/quickstart/text.xml
index 51f9962..d913374 100644
--- a/quickstart/text.xml
+++ b/quickstart/text.xml
@@ -225,11 +225,6 @@ DEPEND="${RDEPEND}
 src_configure() {
        econf --with-popt
 }
-
-src_install() {
-       emake DESTDIR="${D}" install
-       dodoc README CHANGES
-}
 </codesample>
 
 <p>
@@ -241,7 +236,9 @@ variables <d/> see
 </p>
 
 <p>
-Again, we define <c>src_configure</c> and <c>src_install</c> functions.
+We define <c>src_configure</c> only.  <c>src_install</c> does not need to
+be defined since the default implementation calling <c>emake install</c>
+and installing common documentation files works correctly for the package.
 </p>
 
 <p>
@@ -291,11 +288,6 @@ src_prepare() {
 src_configure() {
        econf --with-popt
 }
-
-src_install() {
-       emake DESTDIR="${D}" install
-       dodoc README CHANGES
-}
 </codesample>
 
 <p>
@@ -339,10 +331,6 @@ DEPEND="!sys-libs/glibc"
 src_configure() {
        econf $(use_enable nls)
 }
-
-src_install() {
-       emake DESTDIR="${D}" install
-}
 </codesample>
 
 <p>

Reply via email to