commit:     bdde97ba14e85ea2ca6b128fddca710081334b55
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever <AT> Apache <DOT> Org>
AuthorDate: Mon May 20 01:32:25 2019 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Mon May 20 04:36:32 2019 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=bdde97ba

install-qa-check.d/10ignored-flags: fix false positive

Do not report not respecting LDFLAGS for *.o files with
__gentoo_check_ldflags__ symbol.

Bug: https://bugs.gentoo.org/686356
Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever <AT> Apache.Org>
Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>

 bin/install-qa-check.d/10ignored-flags | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/install-qa-check.d/10ignored-flags 
b/bin/install-qa-check.d/10ignored-flags
index 09bcb57fc..062f51325 100644
--- a/bin/install-qa-check.d/10ignored-flags
+++ b/bin/install-qa-check.d/10ignored-flags
@@ -66,7 +66,7 @@ ignored_flag_check() {
        # Check for files built without respecting LDFLAGS
        if [[ "${LDFLAGS}" == *,--defsym=__gentoo_check_ldflags__* ]] && \
                ! has binchecks ${RESTRICT} ; then
-               f=$(LC_ALL=C comm -3 <(scanelf -qyRF '#k%p' -k .dynsym 
"${ED%/}/" | LC_ALL=C sort) \
+               f=$(LC_ALL=C comm -2 -3 <(scanelf -qyRF '#k%p' -k .dynsym 
"${ED%/}/" | LC_ALL=C sort) \
                        <(scanelf -qyRF '#s%p' -s __gentoo_check_ldflags__ 
"${ED%/}/" | LC_ALL=C sort))
                if [[ -n ${f} ]] ; then
                        echo "${f}" > "${T}"/scanelf-ignored-LDFLAGS.log

Reply via email to