commit: 4ece0aa606656792178aa576a5c2e82ed45fb048 Author: Michał Górny <mgorny <AT> gentoo <DOT> org> AuthorDate: Sun Aug 4 05:13:30 2019 +0000 Commit: Göktürk Yüksek <gokturk <AT> gentoo <DOT> org> CommitDate: Fri Aug 30 15:49:22 2019 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=4ece0aa6
eclass-writing: Word review requirement more strongly Make the review of eclass updates an explicit requirement rather than strong suggestion. Require them unconditionally, providing explicit exception for per-package eclasses. Signed-off-by: Michał Górny <mgorny <AT> gentoo.org> eclass-writing/text.xml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/eclass-writing/text.xml b/eclass-writing/text.xml index ee7d5d0..011a3d5 100644 --- a/eclass-writing/text.xml +++ b/eclass-writing/text.xml @@ -53,12 +53,17 @@ does not require a new eclass will be suggested. </p> <p> -Before updating <c>eutils</c> or a similar widely used eclass, it is best to email -the gentoo-dev list. It may be that your proposed change is broken in a way you -had not anticipated, or that there is an existing function which performs the -same purpose, or that your function may be better off in its own eclass. If you -don't email gentoo-dev first, and end up breaking something, expect to be in a -lot of trouble. +Before updating any eclass, email patches to the gentoo-dev list. It may be that +your proposed change is broken in a way you had not anticipated, or that there +is an existing function which performs the same purpose, or that your function +may be better off in its own eclass. If you don't email gentoo-dev first, +and end up breaking something, expect to be in a lot of trouble. +</p> + +<p> +The exceptions to this rule are per-package eclasses. For example, +the <c>apache-2</c> eclass is only used by the <c>www-servers/apache</c> +package, and thus does not typically require changes to be emailed for review. </p> <p> @@ -73,11 +78,6 @@ If there is an existing maintainer for an eclass (this is usually the case), you <b>must</b> talk to the maintainer before committing any changes. </p> -<p> -It is not usually necessary to email the gentoo-dev list before making changes -to a non-general eclass which you maintain. Use common sense here. -</p> - <warning> Committing a broken eclass can kill huge numbers of packages. Since <c>repoman</c> is not eclass-aware, be very sure you do proper testing.
