commit: 88f38bc955b664741b2473a4316c0b55d622b8ad Author: Matt Turner <mattst88 <AT> gentoo <DOT> org> AuthorDate: Mon Jan 18 03:09:30 2021 +0000 Commit: Matt Turner <mattst88 <AT> gentoo <DOT> org> CommitDate: Mon Jan 18 03:27:41 2021 +0000 URL: https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=88f38bc9
catalyst: Call config_profile_link for all targets This reverts the following two commits, which have no documented rationale. Revert "Set the profile by calling eselect." This reverts commit 90c03f9dc255ba89849e46490f9ead7ab3921950. Revert "Drop config_profile_link from the action_sequence for the generic stage." This reverts commit 3bd10159bf7cfe14b6d8a8218b94eca73be4c997. Doing so improves the code in two ways: 1) it makes prepare_sequence identical across all targets, which will allow me to deduplicate some code 2) it no longer calls eselect profile each time chroot-functions.sh is sourced (even for those targets that were still calling config_profile_link) Signed-off-by: Matt Turner <mattst88 <AT> gentoo.org> catalyst/base/stagebase.py | 1 + targets/support/chroot-functions.sh | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py index 79f00149..5115d029 100644 --- a/catalyst/base/stagebase.py +++ b/catalyst/base/stagebase.py @@ -483,6 +483,7 @@ class StageBase(TargetBase, ClearBase, GenBase): """Set basic stage1, 2, 3 action sequences""" self.prepare_sequence.extend([ self.unpack, + self.config_profile_link, self.setup_confdir, self.portage_overlay, ]) diff --git a/targets/support/chroot-functions.sh b/targets/support/chroot-functions.sh index 2aec018e..88465c31 100755 --- a/targets/support/chroot-functions.sh +++ b/targets/support/chroot-functions.sh @@ -1,8 +1,5 @@ #!/bin/bash -# Set the profile -eselect profile set ${clst_target_profile} - # Trap these signals and kill ourselves if received # Force ourselves to die if any of these signals are received # most likely our controlling terminal is gone