commit:     05fbaf103daecf4746af40048f2c2426ef662b4e
Author:     William Breathitt Gray <vilhelm.gray <AT> gmail <DOT> com>
AuthorDate: Wed Aug 11 00:04:09 2021 +0000
Commit:     William Breathitt Gray <vilhelm.gray <AT> gmail <DOT> com>
CommitDate: Wed Aug 11 00:04:09 2021 +0000
URL:        https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=05fbaf10

games-fps/crispy-doom: [QA] unconditionally install completion files

QA policy [0] says that we don't conditionalise installation of
small files. It's a wasteful rebuild and inconsistent across packages
for when users desire completions to be available.

[0] https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0301
Signed-off-by: William Breathitt Gray <vilhelm.gray <AT> gmail.com>

 games-fps/crispy-doom/crispy-doom-5.10.2.ebuild | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/games-fps/crispy-doom/crispy-doom-5.10.2.ebuild 
b/games-fps/crispy-doom/crispy-doom-5.10.2.ebuild
index 5f559378a..506534c2e 100644
--- a/games-fps/crispy-doom/crispy-doom-5.10.2.ebuild
+++ b/games-fps/crispy-doom/crispy-doom-5.10.2.ebuild
@@ -14,7 +14,7 @@ 
SRC_URI="https://github.com/fabiangreffrath/${PN}/archive/${P}.tar.gz";
 LICENSE="BSD GPL-2+"
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
-IUSE="bash-completion doc libsamplerate +midi png truecolor vorbis zlib"
+IUSE="doc libsamplerate +midi png truecolor vorbis zlib"
 
 DEPEND="
        media-libs/libsdl2[video]
@@ -24,8 +24,9 @@ DEPEND="
        png? ( media-libs/libpng:= )
        zlib? ( sys-libs/zlib )"
 RDEPEND="${DEPEND}"
+# ${PYTHON_DEPS} for bash-completion
 BDEPEND="
-       bash-completion? ( ${PYTHON_DEPS} )
+       ${PYTHON_DEPS}
        doc? ( ${PYTHON_DEPS} )"
 
 S="${WORKDIR}"/${PN}-${P}
@@ -51,7 +52,7 @@ src_prepare() {
 
 src_configure() {
        econf \
-               $(use_enable bash-completion) \
+               --enable-bash-completion \
                $(use_enable doc) \
                --disable-fonts \
                --disable-icons \

Reply via email to